example/with-typescript-plugin

[deptno]

#3694

[sergiodxa]

Not an expert of TS but do we still need to ignore .js files if we are using the webpack loader? I think we are now just using .tsx as a native file format.

[deptno]

You are right, Let me delete it

[sergiodxa]

Is this still true?

[deptno]

I removed that line

[sergiodxa]

I think we can either remove the old example and use this or name it with-typescript-plugin, what do you think @timneutkens?

[sergiodxa]

Maybe maintain the old one for compatibility with old Next.js versions?

[deptno]

replace with-typescript2 -> with-typescript-plugin

[sergiodxa]

Do we still need to preserve JSX?

[deptno]

this option from https://github.com/zeit/next-plugins/tree/master/packages/next-typescript

I’ve tested styled-jsx with jsx option removal,
It works well, I removed from code

[sergiodxa]

@deptno awesome (and super fast) work!

[arunoda]

I think we don't need to the keep the existing. I think this is a great improvement for the existing example and it's no longer will be needed.

@timneutkens your call.

[timneutkens]

yeah please make this with-typescript the old example was a hack.

[deptno]

done

[kachkaev]

Hi guys,

I just used your example to start a new project and noticed this error message from in VSCode:

After a bit of googling, I could solve this by adding "jsx": "preserve" to tsconfig.json and restarting the VSCode's TS server.

What made you remove this key from the config? Should we bring it back?

[timneutkens]

@kachkaev the example should reflect: https://github.com/zeit/next-plugins/tree/master/packages/next-typescript#usage, feel free to create a pull request 🙏