Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with-typescript example to use next-typescript #3694

Closed
1 task done
sergiodxa opened this issue Feb 6, 2018 · 3 comments
Closed
1 task done

Update with-typescript example to use next-typescript #3694

sergiodxa opened this issue Feb 6, 2018 · 3 comments
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@sergiodxa
Copy link
Contributor

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Use new Next.js plugin for TypeScript

Current Behavior

Use a hack to transpile TypeScript to JSX and then let Next.js handle it.

Context

With the release of Next.js v5 the current example with TypeScript is outdated and can be simplified with the new next-typescript plugin.

@sergiodxa sergiodxa added the good first issue Easy to fix issues, good for newcomers label Feb 6, 2018
@isBatak
Copy link

isBatak commented Feb 6, 2018

I would like to write my custom server setup in typescript. Could we get that example also?

@sergiodxa
Copy link
Contributor Author

@isBatak that could be another example for a custom-server-typescript, it should require to run tsc for your server code and then run it as any Node.js server.

@sergiodxa
Copy link
Contributor Author

Fixed on #3698

timneutkens pushed a commit that referenced this issue Feb 22, 2018
* Add custom-server-typescript example (see #3694)

* Fix linting errors in custom-server-typescript

* Provide proper arguments to ts-node.

* Fix import and fix all linting errors.

* Use import in server as well.

* Update nodemon.json
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants