Rework <Link> behavior (backwards compatible) #36436

timneutkens · 2022-04-25T10:02:53Z

⚠️ If you're looking at this PR please read the complete description including the part about incremental adoption.

TLDR:

Official support for <Link href="/about">About</Link> / <Link href="/about"><CustomComponent /></Link> / <Link href="/about"><strong>About</strong></Link> where <Link> always renders <a> without edge cases where it doesn’t render <a>. You'll no longer have to put an empty <a> in <Link> with this enabled.

You can opt-into this behavior by running the codemod and setting newNextLinkBehavior: true in the experimental option in next.config.js.

To run the codemod, run npx @next/codemod new-link in the root of your project.

Full context

Changes to `<Link>`

Added an legacyBehavior prop that defaults to true to preserve the defaults we have today, this will allow to run a codemod on existing codebases to move them to the version where legacyBehavior becomes false by default
When using the new behavior <Link> always renders an <a> instead of having React.cloneElement and passing props onto a child element
When using the new behavior props that can be passed to <a> can be passed to <Link>. Previously you could do something like <Link href="/somewhere"><a target="_blank">Download</a></Link> but with <Link> rendering <a> it now allows these props to be set on link. E.g. <Link href="/somewhere" target="_blank"></Link> / <Link href="/somewhere" className="link"></Link>

Incremental Adoption / Codemod

The main reason we haven't made these changes before is that it breaks pretty much all Next.js apps, which is why I've been hesitant to make this change in the past. I've spent a bunch of time figuring out what the right approach is to rolling this out and ended up with an approach that requires existing apps to run a codemod that automatically opts their <Link> usage into the old behavior in order to keep the app functioning.

This codemod will auto-fix the usage where possible. For example:

When you have <Link href="/about"><a>About</a></Link> it'll auto-fix to <Link href="/about">About</Link>
When you have <Link href="/about"><a onClick={() => console.log('clicked')}>About</a></Link> it'll auto-fix to <Link href="/about" onClick={() => console.log('clicked')}>About</Link>
For cases where auto-fixing can't be applied the legacyBehavior prop is added. When you have <Link href="/about"><Component /></Link> it'll transform to <Link href="/about" legacyBehavior><Component /></Link> so that your app keeps functioning using the old behavior for that particular link. It's then up to the dev to move that case out of the legacyBehavior prop.

This default will be changed in Next.js 13, it does not affect existing apps in Next.js 12 unless opted in via experimental.newNextLinkBehavior and running the codemod.

Some code samples of what changed:

const CustomComponent = () => <strong>Hello</strong>

// Legacy behavior: `<a>` has to be nested otherwise it's excluded

// Renders: <a href="/about">About</a>. `<a>` has to be nested.
<Link href="/about">
  <a>About</a>  
</Link>

// Renders: <strong onClick={nextLinkClickHandler}>Hello</strong>. No `<a>` is included.
<Link href="/about">
  <strong>Hello</strong>
</Link>


// Renders: <strong onClick={nextLinkClickHandler}>Hello</strong>. No `<a>` is included.
<Link href="/about">
  <CustomComponent />
</Link>

// --------------------------------------------------
// New behavior: `<Link>` always renders `<a>`

// Renders: <a href="/about">About</a>. `<a>` no longer has to be nested.
<Link href="/about">
  About
</Link>

// Renders: <a href="/about"><strong>Hello</strong></a>. `<a>` is included.
<Link href="/about">
  <strong>Hello</strong>
</Link>

// Renders: <a href="/about"><strong>Hello</strong></a>. `<a>` is included.
<Link href="/about">
  <CustomComponent />
</Link>

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

- Add onClick / onMouseEnter on Link - Always render `<Link>` with `<a>` (no more nesting `<a>`) - Add `oldBehavior` prop to use the previous behavior - allows for migrating existing link usage. Defaults to `oldBehavior={true}` till the next major version

ijjk · 2022-04-25T10:26:19Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
buildDuration	17.7s	17.9s	⚠️ +134ms
buildDurationCached	6.9s	6.9s	⚠️ +6ms
nodeModulesSize	481 MB	481 MB	⚠️ +4.98 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.89	3.884	-0.01
/ avg req/sec	642.69	643.64	+0.95
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.978	1.899	-0.08
/error-in-render avg req/sec	1263.65	1316.19	+52.54

Client Bundles (main, webpack)

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.3 kB	72.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	192 B	192 B	✓
amp-HASH.js gzip	309 B	309 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	3.04 kB	3.04 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.73 kB	5.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.36 kB	2.63 kB	⚠️ +265 B
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16 kB	16.3 kB	⚠️ +265 B

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
_buildManifest.js gzip	461 B	461 B	✓
Overall change	461 B	461 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Diffs

Diff for _buildManifest.js

@@ -13,7 +13,7 @@ self.__BUILD_MANIFEST = {
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-96a5d6ed07cf5a83.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-9dfe734f583d4926.js"],
   "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-4ebd299a1253d245.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-c605640c895e01ab.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-5b526b867abc83fc.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-98eb70bf22fb21da.js"
   ],

Diff for link-HASH.js

@@ -105,6 +105,34 @@
               default: obj
             };
       }
+      function _objectWithoutProperties(source, excluded) {
+        if (source == null) return {};
+        var target = _objectWithoutPropertiesLoose(source, excluded);
+        var key, i;
+        if (Object.getOwnPropertySymbols) {
+          var sourceSymbolKeys = Object.getOwnPropertySymbols(source);
+          for (i = 0; i < sourceSymbolKeys.length; i++) {
+            key = sourceSymbolKeys[i];
+            if (excluded.indexOf(key) >= 0) continue;
+            if (!Object.prototype.propertyIsEnumerable.call(source, key))
+              continue;
+            target[key] = source[key];
+          }
+        }
+        return target;
+      }
+      function _objectWithoutPropertiesLoose(source, excluded) {
+        if (source == null) return {};
+        var target = {};
+        var sourceKeys = Object.keys(source);
+        var key, i;
+        for (i = 0; i < sourceKeys.length; i++) {
+          key = sourceKeys[i];
+          if (excluded.indexOf(key) >= 0) continue;
+          target[key] = source[key];
+        }
+        return target;
+      }
       var prefetched = {};
       function prefetch(router, href, as, options) {
         if (false || !router) return;
@@ -164,6 +192,11 @@
         });
       }
       function Link(props) {
+        var _legacyBehavior = props.legacyBehavior,
+          legacyBehavior =
+            _legacyBehavior === void 0
+              ? Boolean(false) !== true
+              : _legacyBehavior;
         if (false) {
           var hasWarned,
             optionalProps,
@@ -172,48 +205,72 @@
             requiredPropsGuard,
             createPropError;
         }
-        var p = props.prefetch !== false;
+        var children;
+        var hrefProp = props.href,
+          asProp = props.as,
+          childrenProp = props.children,
+          prefetchProp = props.prefetch,
+          passHref = props.passHref,
+          replace = props.replace,
+          shallow = props.shallow,
+          scroll = props.scroll,
+          locale = props.locale,
+          onClick = props.onClick,
+          onMouseEnter = props.onMouseEnter,
+          restProps = _objectWithoutProperties(props, [
+            "href",
+            "as",
+            "children",
+            "prefetch",
+            "passHref",
+            "replace",
+            "shallow",
+            "scroll",
+            "locale",
+            "onClick",
+            "onMouseEnter"
+          ]);
+        children = childrenProp;
+        if (legacyBehavior && typeof children === "string") {
+          children = /*#__PURE__*/ _react.default.createElement(
+            "a",
+            null,
+            children
+          );
+        }
+        var p = prefetchProp !== false;
         var router = (0, _router1).useRouter();
         var ref2 = _react.default.useMemo(
             function() {
               var ref = _slicedToArray(
-                  (0, _router).resolveHref(router, props.href, true),
+                  (0, _router).resolveHref(router, hrefProp, true),
                   2
                 ),
                 resolvedHref = ref[0],
                 resolvedAs = ref[1];
               return {
                 href: resolvedHref,
-                as: props.as
-                  ? (0, _router).resolveHref(router, props.as)
+                as: asProp
+                  ? (0, _router).resolveHref(router, asProp)
                   : resolvedAs || resolvedHref
               };
             },
-            [router, props.href, props.as]
+            [router, hrefProp, asProp]
           ),
           href = ref2.href,
           as = ref2.as;
         var previousHref = _react.default.useRef(href);
         var previousAs = _react.default.useRef(as);
-        var children = props.children,
-          replace = props.replace,
-          shallow = props.shallow,
-          scroll = props.scroll,
-          locale = props.locale;
-        if (typeof children === "string") {
-          children = /*#__PURE__*/ _react.default.createElement(
-            "a",
-            null,
-            children
-          );
-        }
         // This will return the first child, if multiple are provided it will throw an error
         var child;
-        if (false) {
-        } else {
-          child = _react.default.Children.only(children);
+        if (legacyBehavior) {
+          if (false) {
+          } else {
+            child = _react.default.Children.only(children);
+          }
         }
-        var childRef = child && typeof child === "object" && child.ref;
+        var childRef =
+          legacyBehavior && child && typeof child === "object" && child.ref;
         var ref1 = _slicedToArray(
             (0, _useIntersection).useIntersection({
               rootMargin: "200px"
@@ -232,14 +289,14 @@
               previousHref.current = href;
             }
             setIntersectionRef(el);
-            if (childRef) {
+            if (legacyBehavior && childRef) {
               if (typeof childRef === "function") childRef(el);
               else if (typeof childRef === "object") {
                 childRef.current = el;
               }
             }
           },
-          [as, childRef, href, resetVisible, setIntersectionRef]
+          [as, childRef, href, resetVisible, setIntersectionRef, legacyBehavior]
         );
         _react.default.useEffect(
           function() {
@@ -262,7 +319,14 @@
           onClick: function(e) {
             if (false) {
             }
-            if (child.props && typeof child.props.onClick === "function") {
+            if (!legacyBehavior && typeof onClick === "function") {
+              onClick(e);
+            }
+            if (
+              legacyBehavior &&
+              child.props &&
+              typeof child.props.onClick === "function"
+            ) {
               child.props.onClick(e);
             }
             if (!e.defaultPrevented) {
@@ -277,22 +341,30 @@
                 locale
               );
             }
-          }
-        };
-        childProps.onMouseEnter = function(e) {
-          if (child.props && typeof child.props.onMouseEnter === "function") {
-            child.props.onMouseEnter(e);
-          }
-          if ((0, _router).isLocalURL(href)) {
-            prefetch(router, href, as, {
-              priority: true
-            });
+          },
+          onMouseEnter: function(e) {
+            if (!legacyBehavior && typeof onMouseEnter === "function") {
+              onMouseEnter(e);
+            }
+            if (
+              legacyBehavior &&
+              child.props &&
+              typeof child.props.onMouseEnter === "function"
+            ) {
+              child.props.onMouseEnter(e);
+            }
+            if ((0, _router).isLocalURL(href)) {
+              prefetch(router, href, as, {
+                priority: true
+              });
+            }
           }
         };
         // If child is an <a> tag and doesn't have a href attribute, or if the 'passHref' property is
         // defined, we specify the current 'href', so that repetition is not needed by the user
         if (
-          props.passHref ||
+          !legacyBehavior ||
+          passHref ||
           (child.type === "a" && !("href" in child.props))
         ) {
           var curLocale1 =
@@ -318,7 +390,13 @@
               )
             );
         }
-        return /*#__PURE__*/ _react.default.cloneElement(child, childProps);
+        return legacyBehavior
+          ? /*#__PURE__*/ _react.default.cloneElement(child, childProps)
+          : /*#__PURE__*/ _react.default.createElement(
+              "a",
+              Object.assign({}, restProps, childProps),
+              children
+            );
       }
       var _default = Link;
       exports["default"] = _default;

Diff for link.html

@@ -27,7 +27,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-c605640c895e01ab.js"
+      src="/_next/static/chunks/pages/link-5b526b867abc83fc.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
buildDuration	20.7s	20.5s	-208ms
buildDurationCached	6.8s	7.4s	⚠️ +562ms
nodeModulesSize	481 MB	481 MB	⚠️ +4.98 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.909	3.857	-0.05
/ avg req/sec	639.62	648.1	+8.48
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.899	1.911	⚠️ +0.01
/error-in-render avg req/sec	1316.18	1308.2	⚠️ -7.98

Client Bundles (main, webpack)

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	29.1 kB	29.1 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.9 kB	72.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	313 B	313 B	✓
css-HASH.js gzip	325 B	325 B	✓
dynamic-HASH.js gzip	3.02 kB	3.02 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.78 kB	5.78 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.44 kB	2.74 kB	⚠️ +305 B
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	393 B	393 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.1 kB	16.4 kB	⚠️ +305 B

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
_buildManifest.js gzip	457 B	457 B	✓
Overall change	457 B	457 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/that-link-change-we-always-wanted-to-do	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	542 B	-2 B
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	-2 B

Diffs

Diff for _buildManifest.js

@@ -13,7 +13,7 @@ self.__BUILD_MANIFEST = {
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-96a5d6ed07cf5a83.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-9dfe734f583d4926.js"],
   "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-4ebd299a1253d245.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-c605640c895e01ab.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-5b526b867abc83fc.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-98eb70bf22fb21da.js"
   ],

Diff for link-HASH.js

@@ -105,6 +105,34 @@
               default: obj
             };
       }
+      function _objectWithoutProperties(source, excluded) {
+        if (source == null) return {};
+        var target = _objectWithoutPropertiesLoose(source, excluded);
+        var key, i;
+        if (Object.getOwnPropertySymbols) {
+          var sourceSymbolKeys = Object.getOwnPropertySymbols(source);
+          for (i = 0; i < sourceSymbolKeys.length; i++) {
+            key = sourceSymbolKeys[i];
+            if (excluded.indexOf(key) >= 0) continue;
+            if (!Object.prototype.propertyIsEnumerable.call(source, key))
+              continue;
+            target[key] = source[key];
+          }
+        }
+        return target;
+      }
+      function _objectWithoutPropertiesLoose(source, excluded) {
+        if (source == null) return {};
+        var target = {};
+        var sourceKeys = Object.keys(source);
+        var key, i;
+        for (i = 0; i < sourceKeys.length; i++) {
+          key = sourceKeys[i];
+          if (excluded.indexOf(key) >= 0) continue;
+          target[key] = source[key];
+        }
+        return target;
+      }
       var prefetched = {};
       function prefetch(router, href, as, options) {
         if (false || !router) return;
@@ -164,6 +192,11 @@
         });
       }
       function Link(props) {
+        var _legacyBehavior = props.legacyBehavior,
+          legacyBehavior =
+            _legacyBehavior === void 0
+              ? Boolean(false) !== true
+              : _legacyBehavior;
         if (false) {
           var hasWarned,
             optionalProps,
@@ -172,48 +205,72 @@
             requiredPropsGuard,
             createPropError;
         }
-        var p = props.prefetch !== false;
+        var children;
+        var hrefProp = props.href,
+          asProp = props.as,
+          childrenProp = props.children,
+          prefetchProp = props.prefetch,
+          passHref = props.passHref,
+          replace = props.replace,
+          shallow = props.shallow,
+          scroll = props.scroll,
+          locale = props.locale,
+          onClick = props.onClick,
+          onMouseEnter = props.onMouseEnter,
+          restProps = _objectWithoutProperties(props, [
+            "href",
+            "as",
+            "children",
+            "prefetch",
+            "passHref",
+            "replace",
+            "shallow",
+            "scroll",
+            "locale",
+            "onClick",
+            "onMouseEnter"
+          ]);
+        children = childrenProp;
+        if (legacyBehavior && typeof children === "string") {
+          children = /*#__PURE__*/ _react.default.createElement(
+            "a",
+            null,
+            children
+          );
+        }
+        var p = prefetchProp !== false;
         var router = (0, _router1).useRouter();
         var ref2 = _react.default.useMemo(
             function() {
               var ref = _slicedToArray(
-                  (0, _router).resolveHref(router, props.href, true),
+                  (0, _router).resolveHref(router, hrefProp, true),
                   2
                 ),
                 resolvedHref = ref[0],
                 resolvedAs = ref[1];
               return {
                 href: resolvedHref,
-                as: props.as
-                  ? (0, _router).resolveHref(router, props.as)
+                as: asProp
+                  ? (0, _router).resolveHref(router, asProp)
                   : resolvedAs || resolvedHref
               };
             },
-            [router, props.href, props.as]
+            [router, hrefProp, asProp]
           ),
           href = ref2.href,
           as = ref2.as;
         var previousHref = _react.default.useRef(href);
         var previousAs = _react.default.useRef(as);
-        var children = props.children,
-          replace = props.replace,
-          shallow = props.shallow,
-          scroll = props.scroll,
-          locale = props.locale;
-        if (typeof children === "string") {
-          children = /*#__PURE__*/ _react.default.createElement(
-            "a",
-            null,
-            children
-          );
-        }
         // This will return the first child, if multiple are provided it will throw an error
         var child;
-        if (false) {
-        } else {
-          child = _react.default.Children.only(children);
+        if (legacyBehavior) {
+          if (false) {
+          } else {
+            child = _react.default.Children.only(children);
+          }
         }
-        var childRef = child && typeof child === "object" && child.ref;
+        var childRef =
+          legacyBehavior && child && typeof child === "object" && child.ref;
         var ref1 = _slicedToArray(
             (0, _useIntersection).useIntersection({
               rootMargin: "200px"
@@ -232,14 +289,14 @@
               previousHref.current = href;
             }
             setIntersectionRef(el);
-            if (childRef) {
+            if (legacyBehavior && childRef) {
               if (typeof childRef === "function") childRef(el);
               else if (typeof childRef === "object") {
                 childRef.current = el;
               }
             }
           },
-          [as, childRef, href, resetVisible, setIntersectionRef]
+          [as, childRef, href, resetVisible, setIntersectionRef, legacyBehavior]
         );
         _react.default.useEffect(
           function() {
@@ -262,7 +319,14 @@
           onClick: function(e) {
             if (false) {
             }
-            if (child.props && typeof child.props.onClick === "function") {
+            if (!legacyBehavior && typeof onClick === "function") {
+              onClick(e);
+            }
+            if (
+              legacyBehavior &&
+              child.props &&
+              typeof child.props.onClick === "function"
+            ) {
               child.props.onClick(e);
             }
             if (!e.defaultPrevented) {
@@ -277,22 +341,30 @@
                 locale
               );
             }
-          }
-        };
-        childProps.onMouseEnter = function(e) {
-          if (child.props && typeof child.props.onMouseEnter === "function") {
-            child.props.onMouseEnter(e);
-          }
-          if ((0, _router).isLocalURL(href)) {
-            prefetch(router, href, as, {
-              priority: true
-            });
+          },
+          onMouseEnter: function(e) {
+            if (!legacyBehavior && typeof onMouseEnter === "function") {
+              onMouseEnter(e);
+            }
+            if (
+              legacyBehavior &&
+              child.props &&
+              typeof child.props.onMouseEnter === "function"
+            ) {
+              child.props.onMouseEnter(e);
+            }
+            if ((0, _router).isLocalURL(href)) {
+              prefetch(router, href, as, {
+                priority: true
+              });
+            }
           }
         };
         // If child is an <a> tag and doesn't have a href attribute, or if the 'passHref' property is
         // defined, we specify the current 'href', so that repetition is not needed by the user
         if (
-          props.passHref ||
+          !legacyBehavior ||
+          passHref ||
           (child.type === "a" && !("href" in child.props))
         ) {
           var curLocale1 =
@@ -318,7 +390,13 @@
               )
             );
         }
-        return /*#__PURE__*/ _react.default.cloneElement(child, childProps);
+        return legacyBehavior
+          ? /*#__PURE__*/ _react.default.cloneElement(child, childProps)
+          : /*#__PURE__*/ _react.default.createElement(
+              "a",
+              Object.assign({}, restProps, childProps),
+              children
+            );
       }
       var _default = Link;
       exports["default"] = _default;

Diff for link.html

@@ -27,7 +27,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-c605640c895e01ab.js"
+      src="/_next/static/chunks/pages/link-5b526b867abc83fc.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>

Commit: d558a91

jacobrask · 2022-04-25T14:32:18Z

Nice incremental approach! Would a name like autoForwardProps or similar be more self explanatory both in the component props and config options? What if there’s an even newer link behavior some time from now?

timneutkens · 2022-04-25T14:38:18Z

Nice incremental approach! Would a name like autoForwardProps or similar be more self explanatory both in the component props and config options? What if there’s an even newer link behavior some time from now?

It's much more complicated than just forwarding the props, e.g. React.cloneElement is used and it doesn't actually forward props, it adds onClick onto the child component and you can't add props that <a> would generally have onto <Link> in today's <Link>.

The general idea of the prop is that oldBehavior is something you never manually add to your application's links, it's something the codemod adds for you that can then be cleaned up / fixed at a later point in time. This way your app does not get stuck on an older version just because you built it on Next.js 12 and below.

BButner · 2022-04-25T14:51:47Z

Are there plans to move className into Link, for easier styling? That way we wouldn't have to wrap the child text in any other element, and the styling would be passed from Link to the a tag?

timneutkens · 2022-04-25T15:25:24Z

Are there plans to move className into Link, for easier styling? That way we wouldn't have to wrap the child text in any other element, and the styling would be passed from Link to the a tag?

This is covered by this PR already and included in the tests: https://github.com/vercel/next.js/pull/36436/files#diff-e252bd01564b73f2c5d306ae70bb85f4b0022712b4e64225cc1a8f1e547469d7.

It is mentioned by the third item in changes to <Link> that all props <a> can take are supported on <Link>, this includes className. I've added an example using className to that item 👍

BButner · 2022-04-25T15:32:10Z

Are there plans to move className into Link, for easier styling? That way we wouldn't have to wrap the child text in any other element, and the styling would be passed from Link to the a tag?

This is covered by this PR already and included in the tests: https://github.com/vercel/next.js/pull/36436/files#diff-e252bd01564b73f2c5d306ae70bb85f4b0022712b4e64225cc1a8f1e547469d7.

It is mentioned by the third item in changes to <Link> that all props <a> can take are supported on <Link>, this includes className. I've added an example using className to that item 👍

My apologies, I didn't read that thoroughly enough. This change is awesome ♥

timneutkens · 2022-04-25T15:34:05Z

@BButner no worries, easy to miss, lot of content in this PR 👍

SuttonJack

lgtm

packages/next/server/config-shared.ts

packages/next/client/link.tsx

sammdec · 2022-04-25T20:16:00Z

We use a custom a element created by stitches, how will this work with the css prop that stitches creates?

timneutkens · 2022-04-26T09:00:09Z

We use a custom a element created by stitches, how will this work with the css prop that stitches creates?

@sammdec it just works: https://github.com/vercel/next.js/pull/36474/files#diff-43f403de29e5b69987940b10d46c7409b7663f4a57fd16ee07ce9574e893b840R12-R16. This test is based on the existing example in the examples dir.

sammdec · 2022-04-26T09:07:44Z

@timneutkens and does link work for both internal links and external links e.g https://

timneutkens · 2022-04-26T09:09:12Z

@timneutkens and does link work for both internal links and external links e.g https://

Yes, it has for a while now, can't remember which version exactly but somewhere around Next.js 9.2 I think.

sammdec · 2022-04-26T09:10:45Z

Woah totally missed that one! Time to get updating!

Ref: vercel/next.js#36511 Ref: vercel/next.js#36436

andrewscofield · 2022-05-05T15:40:02Z

@timneutkens Just ran the codemod on a site and it worked 99% for me. The only issue I ran into was a couple spots where I had for example:

<Link href="/products">
  <a>
    <Image ... />
    <h1>{title}</h1>
  </a>
</Link>

The code mode transformed it into:

<Link href="/products">
    <Image ... />
    <h1>{title}</h1>
</Link>

Causing this error: https://nextjs.org/docs/messages/link-multiple-children

But other wise it worked perfect for me. Just thought I'd give you a heads up, I think this could be a common scenario.

timneutkens · 2022-05-05T15:45:31Z

@andrewscofield that means you didn't enable the experimental flag for the new behavior with experimental.newNextLinkBehavior as it's a message that can't be run into in the new behavior:

// next.config.js
module.exports = {
  experimental: {
    newNextLinkBehavior: true
  }
}

andrewscofield · 2022-05-05T15:50:51Z

Ahh ok that fixed it. I must have been looking at an old commit or something because I had it setup as experimental.newLinkBehavior Thanks, I'm a big fan of this change!

SukkaW · 2022-05-12T13:49:48Z

FYI, here is my thought about how to migrate <Link href="/about"><Component /></Link> to new Next.js link behavior:

styled component:

- const Component = styled.a`color: red;`;
+ const Component = styled(Link)`color: red`;

// non-"standard" styled components, E.g. styletron.org:
- const Component = styled('a', { color: 'red' });
+ const Component = styled(Link, { color: 'red' });

- <Link href="/about"><Component /></Link>
+ <Component href="/about" />

custom component:

- const Component = forwardRef((props, ref) => <a  {...props} sx={{ color: 'red' }} ref={ref} />);
+ const Component = forwardRef((props, ref) => <Link  {...props} sx={{ color: 'red' }} ref={ref} />);

- <Link href="/about"><Component /></Link>
+ <Component href="/about" />

TBD

When Next.js 13 is finally released and legacyBehavior is removed, here is what Next.js should include in the migration guide.

timneutkens · 2022-05-12T19:52:23Z

When Next.js 13 is finally released and legacyBehavior is removed, here is what Next.js should include in the migration guide.

legacyBehavior won't be removed in Next.js 13, it's part of the incremental adoption strategy. We'll want to provide how to update code that hit legacyBehavior through the codemod in the upgrade guide though 👍

danielpl10 · 2022-05-17T16:13:30Z

Hi, from what version can I use this behavior? I'm on 12.1.6 and the only way this work for me was putting legacyBehavior={false} on the Link component

stefanprobst · 2022-05-19T19:50:48Z

how would the following look like with the new behavior?:

import Link from '@mui/material/Link';
import NextLink from 'next/link';

<NextLink href="/" passHref>
  <Link>Home</Link>
</NextLink>

robertwbradford · 2022-06-02T21:57:41Z

how would the following look like with the new behavior?:

import Link from '@mui/material/Link';
import NextLink from 'next/link';

<NextLink href="/" passHref>
  <Link>Home</Link>
</NextLink>

Would something like this work for the API?

import Link from '@mui/material/Link';
import NextLink from 'next/link';

<NextLink href="/" as={Link}>
  Home
</NextLink>

Where it renders using the Link component but attaches all the next/link behavior. as would default to "a".

SukkaW · 2022-06-03T04:05:12Z

how would the following look like with the new behavior?:
import Link from '@mui/material/Link';
import NextLink from 'next/link';

<NextLink href="/" passHref>
  <Link>Home</Link>
</NextLink>
Would something like this work for the API?
import Link from '@mui/material/Link';
import NextLink from 'next/link';

<NextLink href="/" as={Link}>
  Home
</NextLink>
Where it renders using the Link component but attaches all the next/link behavior. as would default to "a".

No. And here is the proper way of doing it:

import Link from '@mui/material/Link';
import NextLink from 'next/link';

<Link href="/" as={NextLink}>
  Home
</Link>

blakeplumb · 2022-06-29T22:48:11Z

So for all custom link components we want to use, we have to hope there is an as like property that will accept NextLink. Makes more sense to me to have NextLink handle this instead. @timneutkens Could you please help clarify this behavior as it's becoming a road block for my team in implementing this feature.

christiankaindl · 2022-06-30T14:08:32Z

If anyone is getting an error "Invalid transform choice" when running the codemod, then add the version to the npx command:

npx @next/[email protected] new-link

Then it worked for me :)

timneutkens added 3 commits April 24, 2022 19:53

Add new link behavior

ddaafb8

- Add onClick / onMouseEnter on Link - Always render `<Link>` with `<a>` (no more nesting `<a>`) - Add `oldBehavior` prop to use the previous behavior - allows for migrating existing link usage. Defaults to `oldBehavior={true}` till the next major version

Add tests and support for passing any <a> prop

d09a64a

Add codemod and newLinkBehavior option to opt-in to the new default

ad1b58c

timneutkens requested review from ijjk, shuding, padmaia and huozhi as code owners April 25, 2022 10:02

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Apr 25, 2022

This comment was marked as outdated.

Sign in to view

timneutkens added 2 commits April 25, 2022 12:49

Fix test

21fe9e6

Fix test

a4fc825

Move tests to using experimental flag. Add test for multiple children.

4645292

SuttonJack previously approved these changes Apr 25, 2022

View reviewed changes

ijjk reviewed Apr 25, 2022

View reviewed changes

packages/next/server/config-shared.ts Outdated Show resolved Hide resolved

ijjk reviewed Apr 25, 2022

View reviewed changes

packages/next/client/link.tsx Outdated Show resolved Hide resolved

ijjk reviewed Apr 25, 2022

View reviewed changes

packages/next/client/link.tsx Outdated Show resolved Hide resolved

ijjk reviewed Apr 25, 2022

View reviewed changes

packages/next/client/link.tsx Outdated Show resolved Hide resolved

Still show warning with new behavior

8a695e0

timneutkens dismissed SuttonJack’s stale review via 8a695e0 April 25, 2022 17:07

Add codemod tests for cases observed in the vercel.com app

c7c3bfe

bretthayes mentioned this pull request Apr 25, 2022

Create simpler Link component and use it throughout the codebase sourcegraph/about-replatform#30

Closed

kodiakhq bot merged commit 489e65e into vercel:canary Apr 25, 2022

timneutkens deleted the add/that-link-change-we-always-wanted-to-do branch April 26, 2022 07:12

karlhorky added a commit to upleveled/eslint-config-upleveled that referenced this pull request May 2, 2022

Remove obsolete rule in preparation for Next v13

8be3387

Ref: vercel/next.js#36511 Ref: vercel/next.js#36436

ZeeshanTamboli mentioned this pull request May 6, 2022

[examples] NextLinkComposedProps gives a TypeScript error mui/material-ui#32592

Closed

2 tasks

tnurzynski mentioned this pull request May 10, 2022

TypeScript error when extending LinkProps #36800

Closed

1 task

Brennvo mentioned this pull request May 30, 2022

"onMouseEnter" was passed to <Link> with href of / but "legacyBehavior" was set chakra-ui/chakra-ui#6105

Closed

3 tasks

This was referenced Jun 22, 2022

ci(changesets): next version packages refinedev/refine#2023

Merged

ci(changesets): version packages refinedev/refine#2034

Merged

numToStr mentioned this pull request Jul 2, 2022

Support experimental.newNextLinkBehavior setting shuding/nextra#500

Closed

azu mentioned this pull request Jul 4, 2022

2022-07-04のJS: Next.js 12.2、Fresh 1.0(Deno Web Framework)、Vue 2.7(2.xの最終minor) jser/jser.github.io#997

Merged

bretthayes mentioned this pull request Jul 18, 2022

Add missing CTA tracking attributes sourcegraph/about#5574

Merged

balazsorban44 mentioned this pull request Jul 20, 2022

Docs: legacyBehavior #38819

Closed

nirtamir2 mentioned this pull request Jul 25, 2022

Next 12.2 newNextLinkBehavior support RyanClementsHax/storybook-addon-next#110

Closed

riffbyte mentioned this pull request Jul 28, 2022

[TF-1008 TF-960] Create Button component based on design prezly/theme-nextjs-marcel#153

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework <Link> behavior (backwards compatible) #36436

Rework <Link> behavior (backwards compatible) #36436

timneutkens commented Apr 25, 2022 •

edited by jescalan

Loading

This comment was marked as outdated.

ijjk commented Apr 25, 2022 •

edited

Loading

Diffs

Diffs

jacobrask commented Apr 25, 2022

timneutkens commented Apr 25, 2022

BButner commented Apr 25, 2022

timneutkens commented Apr 25, 2022 •

edited

Loading

BButner commented Apr 25, 2022

timneutkens commented Apr 25, 2022

SuttonJack left a comment

sammdec commented Apr 25, 2022

timneutkens commented Apr 26, 2022

sammdec commented Apr 26, 2022

timneutkens commented Apr 26, 2022

sammdec commented Apr 26, 2022

andrewscofield commented May 5, 2022

timneutkens commented May 5, 2022

andrewscofield commented May 5, 2022

SukkaW commented May 12, 2022 •

edited

Loading

timneutkens commented May 12, 2022

danielpl10 commented May 17, 2022

stefanprobst commented May 19, 2022

robertwbradford commented Jun 2, 2022

SukkaW commented Jun 3, 2022 •

edited

Loading

blakeplumb commented Jun 29, 2022 •

edited

Loading

christiankaindl commented Jun 30, 2022

Rework <Link> behavior (backwards compatible) #36436

Rework <Link> behavior (backwards compatible) #36436

Conversation

timneutkens commented Apr 25, 2022 • edited by jescalan Loading

TLDR:

Full context

Changes to <Link>

Incremental Adoption / Codemod

Feature

This comment was marked as outdated.

ijjk commented Apr 25, 2022 • edited Loading

Stats from current PR

Diffs

Diffs

jacobrask commented Apr 25, 2022

timneutkens commented Apr 25, 2022

BButner commented Apr 25, 2022

timneutkens commented Apr 25, 2022 • edited Loading

BButner commented Apr 25, 2022

timneutkens commented Apr 25, 2022

SuttonJack left a comment

Choose a reason for hiding this comment

sammdec commented Apr 25, 2022

timneutkens commented Apr 26, 2022

sammdec commented Apr 26, 2022

timneutkens commented Apr 26, 2022

sammdec commented Apr 26, 2022

andrewscofield commented May 5, 2022

timneutkens commented May 5, 2022

andrewscofield commented May 5, 2022

SukkaW commented May 12, 2022 • edited Loading

timneutkens commented May 12, 2022

danielpl10 commented May 17, 2022

stefanprobst commented May 19, 2022

robertwbradford commented Jun 2, 2022

SukkaW commented Jun 3, 2022 • edited Loading

blakeplumb commented Jun 29, 2022 • edited Loading

christiankaindl commented Jun 30, 2022

timneutkens commented Apr 25, 2022 •

edited by jescalan

Loading

Changes to `<Link>`

ijjk commented Apr 25, 2022 •

edited

Loading

timneutkens commented Apr 25, 2022 •

edited

Loading

SukkaW commented May 12, 2022 •

edited

Loading

SukkaW commented Jun 3, 2022 •

edited

Loading

blakeplumb commented Jun 29, 2022 •

edited

Loading