Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing CTA tracking attributes #5574

Merged
merged 22 commits into from
Jul 20, 2022
Merged

Add missing CTA tracking attributes #5574

merged 22 commits into from
Jul 20, 2022

Conversation

st0nebreaker
Copy link
Contributor

@st0nebreaker st0nebreaker commented Jul 11, 2022 •
edited
Loading

Closes #5487, adds missing CTA's

Changelog

  • Adds missing CTA's data attributes
  • Moves <Tab /> active style override to global stylesheets to keep them uniformed. In accordance with Figma's specs.
  • Turns Footer links into an array to loop through & reduce redundant html.

Notes

Test

  1. Ensure prettier has standardized the proposed changes.

@st0nebreaker st0nebreaker added team/content-platform sprint-rollover Urgent Needs immediate attention and action (use sparingly) analytics labels Jul 11, 2022
@st0nebreaker st0nebreaker added this to the A - Sprint 8 milestone Jul 11, 2022
@st0nebreaker st0nebreaker self-assigned this Jul 11, 2022
@st0nebreaker st0nebreaker marked this pull request as ready for review July 12, 2022 17:00
@st0nebreaker st0nebreaker requested a review from bretthayes July 12, 2022 17:00
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jul 12, 2022 •
edited
Loading

Notifying subscribers in CODENOTIFY files for diff 59f743d...98ec7c9.

Notify File(s)
@content-platform-team src/components/Blockquote.tsx
src/components/Blog/BlogHeader.tsx
src/components/Blog/LinkPost.tsx
src/components/Blog/PodcastListItem.tsx
src/components/Blog/PostLayout.tsx
src/components/Blog/PostListItem.tsx
src/components/Blog/ReleasePost.tsx
src/components/BlogResourceItem.tsx
src/components/CaseStudies/CaseStudyCard.tsx
src/components/CaseStudies/CaseStudyLayout.tsx
src/components/CustomerLogos.tsx
src/components/FeatureWalkthrough/index.tsx
src/components/Install/index.tsx
src/components/IntegrationsSection.tsx
src/components/Layout/Footer.tsx
src/components/Layout/Header/DesktopNav.tsx
src/components/Layout/Header/MobileNav.tsx
src/components/Layout/Header/index.tsx
src/components/Layout/Header/navLinks.ts
src/components/Layout/index.tsx
src/components/Layout/navLinks.tsx
src/components/LeadershipSection.tsx
src/components/Podcast/PodcastSubscribeLinks.tsx
src/components/Pricing/PricingPlan.tsx
src/components/RequestDemoForm.tsx
src/components/RequestDemoTrySourcegraph.tsx
src/components/SelfHostedSection.tsx
src/components/TrySourcegraph.tsx
src/components/WhitePaperPage/index.tsx
src/data/tracking.ts
src/pages/about.tsx
src/pages/accelerate-dev-onboarding.tsx
src/pages/batch-changes.tsx
src/pages/better-dev-onboarding.tsx
src/pages/case-studies/convoy-improved-on-boarding.tsx
src/pages/case-studies/indeed-accelerates-development-velocity.tsx
src/pages/case-studies/nutanix-fixed-log4j-with-sourcegraph.tsx
src/pages/case-studies/sofi-moves-fast-on-hundreds-of-microservices.tsx
src/pages/case-studies/workiva-automates-large-scale-code-changes.tsx
src/pages/code-insights.tsx
src/pages/code-search.tsx
src/pages/community.tsx
src/pages/contact/index.tsx
src/pages/fixing-vulnerabilities.tsx
src/pages/get-started/cloud.tsx
src/pages/get-started/index.tsx
src/pages/get-started/self-hosted.tsx
src/pages/hackathons.tsx
src/pages/home/_Hero.tsx
src/pages/home/_UseCases.tsx
src/pages/jobs.tsx
src/pages/news/index.tsx
src/pages/partner-podcast.tsx
src/pages/pricing.tsx
src/pages/resources/abcs-book.tsx
src/pages/support.tsx
src/pages/use-cases/code-health.tsx
src/pages/use-cases/code-reuse.tsx
src/pages/use-cases/code-security.tsx
src/pages/use-cases/incident-response.tsx
src/pages/use-cases/index.tsx
src/pages/use-cases/onboarding.tsx
src/pages/white-papers/remote-work-easier.tsx
src/styles/globals.scss
src/styles/pages/_code-insights.scss

bretthayes
bretthayes suggested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@bretthayes bretthayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job on this Becca! ✨ Also love the cleanup and efficiency changes you made with our footer links! 😄

Just a few things to fix up below:

src/components/Blockquote.tsx Outdated Show resolved Hide resolved
src/components/Blog/PostListItem.tsx Outdated Show resolved Hide resolved
src/components/CaseStudies/CaseStudyCard.tsx Outdated Show resolved Hide resolved
src/components/Layout/Footer.tsx Outdated Show resolved Hide resolved
src/components/Layout/Footer.tsx Outdated Show resolved Hide resolved
src/components/Blog/PodcastListItem.tsx Outdated Show resolved Hide resolved
@st0nebreaker st0nebreaker requested a review from bretthayes July 20, 2022 00:16
bretthayes
bretthayes previously approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@bretthayes bretthayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for tackling all the links!

An idea just came to mind for a future improvement to be more efficient with tracking. Instead of adding data attributes to every link element, which can be quite the manually-intensive task, I think we can create a hook instead with some conditions. 💡 I created #5594 as a follow up. Let's merge this for now and I'll tackle that soon.

src/data/tracking.ts
@@ -7,6 +7,7 @@ export const buttonStyle = {
textWithBoxedArrow: 4,
outlineWithArrow: 5,
text: 6,
image: 7,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎 literally tracking all the things lol. This will also make more sense when we eventually rename buttonStyle to ctaStyle etc. in the near future.

@st0nebreaker
Copy link
Contributor Author

An idea just came to mind for a future improvement to be more efficient with tracking. Instead of adding data attributes to every link element, which can be quite the manually-intensive task, I think we can create a hook instead with some conditions. 💡 I created #5594 as a follow up. Let's merge this for now and I'll tackle that soon.

That sounds more efficient & clean for the templates 🙌🏻 thanks!

@st0nebreaker st0nebreaker requested a review from bretthayes July 20, 2022 20:57
@st0nebreaker st0nebreaker merged commit 214c827 into main Jul 20, 2022
@st0nebreaker st0nebreaker deleted the cta-audit branch July 20, 2022 21:51
@elzannewentzel elzannewentzel mentioned this pull request Jul 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretthayes bretthayes bretthayes approved these changes

Assignees

@st0nebreaker st0nebreaker

Labels
analytics sprint-rollover Urgent Needs immediate attention and action (use sparingly)
Projects
No open projects
Content Platform Work
Status: Done ✅
Milestone
A - Sprint 9
Development

Successfully merging this pull request may close these issues.

Add missing CTA tracking attributes
4 participants
@st0nebreaker @sourcegraph-bot @bretthayes @elzannewentzel