Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dotenv from with-stripe-typescript #15814

Merged
merged 2 commits into from
Aug 5, 2020
Merged

remove dotenv from with-stripe-typescript #15814

merged 2 commits into from
Aug 5, 2020

Conversation

darshkpatel
Copy link
Contributor

removed the dotenv dependency in favor of Next.js environment support: #15225

The example seems to work with no other changes required
Screenshot 2020-08-03 at 12 03 22 PM

@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 3, 2020
@ijjk
Copy link
Member

ijjk commented Aug 3, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
buildDuration 13.9s 13.6s -309ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.441 2.559 ⚠️ +0.12
/ avg req/sec 1024.29 976.87 ⚠️ -47.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.446 1.525 ⚠️ +0.08
/error-in-render avg req/sec 1728.83 1639.32 ⚠️ -89.51
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
677f882d2ed8..39a4.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5b25689..c07a.js gzip 6.73 kB 6.73 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-6ac1f4e..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
index.html gzip 946 B 946 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
buildDuration 15.3s 14.9s -397ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
677f882d2ed8..39a4.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5b25689..c07a.js gzip 6.73 kB 6.73 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-6ac1f4e..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: b6adfc4

Timer
Timer approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
buildDuration 13.9s 13.8s -49ms
nodeModulesSize 66 MB 66 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.563 2.51 -0.05
/ avg req/sec 975.42 996.21 +20.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.593 1.555 -0.04
/error-in-render avg req/sec 1569.43 1608.06 +38.63
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
index.html gzip 945 B 945 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
buildDuration 15.2s 15.3s ⚠️ +143ms
nodeModulesSize 66 MB 66 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary MLH-Fellowship/next.js darsh/15225 Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: eb5d754

@kodiakhq kodiakhq bot merged commit 885b406 into vercel:canary Aug 5, 2020
@timneutkens timneutkens deleted the darsh/15225 branch August 5, 2020 13:14
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darshkpatel @ijjk @Timer