Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dotenv from all Next.js examples #15225

Closed
3 of 5 tasks
Timer opened this issue Jul 16, 2020 · 9 comments
Closed
3 of 5 tasks

Remove dotenv from all Next.js examples #15225

Timer opened this issue Jul 16, 2020 · 9 comments
Labels
examples Issue was opened via the examples template. good first issue Easy to fix issues, good for newcomers
Milestone
backlog

Comments

@Timer
Copy link
Member

Timer commented Jul 16, 2020 •
edited by timneutkens
Loading

We should remove the dotenv dependency from all Next.js examples (in favor of Next.js environment support):

  • examples/auth0
  • examples/with-firebase/package.json
  • examples/with-reason-relay/package.json
  • examples/with-stripe-typescript/package.json
  • examples/with-universal-configuration-build-time/package.json
@Timer Timer added good first issue Easy to fix issues, good for newcomers examples Issue was opened via the examples template. kind: story labels Jul 16, 2020
@Nishikoh
Copy link

Hi, I'd like to tackle that.

@Timer
Copy link
Member Author

Timer commented Jul 16, 2020

All yours!

@Nishikoh
Copy link

There is something I would like to confirm. I'll remove dotenv dependency from just each package.json. If I need to edit other files, please tell me the details.

@galanggg
Copy link
Contributor

hi @Timer so I just remove the dotenv dependency from all of 5 examples that you point that?

@Nishikoh Nishikoh mentioned this issue Jul 21, 2020
Closed
5 tasks
@Timer
Copy link
Member Author

Timer commented Jul 22, 2020

Well the examples need updated to leverage the new environment support, it's a bit involved!

@msreekm msreekm mentioned this issue Jul 22, 2020
Merged
@msreekm
Copy link
Contributor

msreekm commented Jul 22, 2020 •
edited
Loading

@Timer , created a PR for auth0 example ,rest will create PR soon.

@matamatanot matamatanot mentioned this issue Jul 31, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Aug 2, 2020
@msreekm
Remove dotenv from auth0 Next.js example (#15398)
9f92819 
We should remove the dotenv dependency from all Next.js examples (in favor of Next.js environment support):
#15225
@darshkpatel darshkpatel mentioned this issue Aug 3, 2020
Merged
@msreekm msreekm mentioned this issue Aug 3, 2020
Closed
kodiakhq bot pushed a commit that referenced this issue Aug 4, 2020
@matamatanot
Remove dotenv from with-firebase example (#15743)
9ca670d 
Remove the dotenv dependency from all examples (in favor of environment support): #15225

All variables are exposed to the client. This Example does not use firebase-admin.
kodiakhq bot pushed a commit that referenced this issue Aug 5, 2020
@darshkpatel
remove dotenv from with-stripe-typescript (#15814)
885b406 
removed the dotenv dependency in favor of Next.js environment support: #15225

The example seems to work with no other changes required
![Screenshot 2020-08-03 at 12 03 22 PM](https://user-images.githubusercontent.com/11258286/89152753-557d6480-d581-11ea-919c-4b89a6bec4b6.png)
LauraBeatris pushed a commit to LauraBeatris/next.js that referenced this issue Sep 1, 2020
@msreekm @LauraBeatris
Remove dotenv from auth0 Next.js example (vercel#15398)
86b92e7 
We should remove the dotenv dependency from all Next.js examples (in favor of Next.js environment support):
vercel#15225
@Timer Timer added this to the backlog milestone Sep 7, 2020
@leerob leerob mentioned this issue Feb 3, 2021
Merged
@fwuensche
Copy link
Contributor

Hi there, it seems examples/with-universal-configuration-build-time/package.json has been cleaned up already by this PR #15228. Should we just delete that folder or it makes sense to keep it with the README file only?

kodiakhq bot pushed a commit that referenced this issue Feb 3, 2021
@leerob
Remove dotenv from Relay example. (#21814)
5536526 
Address one of the bullet points from #15225 to remove unused dependencies on `dotenv` now that it's supported by default in Next.js.
@balazsorban44
Copy link
Member

balazsorban44 commented Dec 24, 2021 •
edited
Loading

As far as I can tell, this has been addressed.

As of writing, the only reference was in with-mysql, which used dotenv for a different purpose.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
examples Issue was opened via the examples template. good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
6 participants
@Timer @msreekm @fwuensche @balazsorban44 @galanggg @Nishikoh