-
Notifications
You must be signed in to change notification settings - Fork 27.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure app chunk URLs are encoded properly (#46749
This ensures we properly encode chunks for app dir the same we do for pages. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) x-ref: #8435
- Loading branch information
Showing
6 changed files
with
68 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
test/e2e/app-dir/app/app/dynamic-client/[category]/[id]/layout.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
export default function IdLayout({ children, params }) { | ||
return ( | ||
<> | ||
<h3> | ||
Id Layout. Params:{' '} | ||
<span id="id-layout-params">{JSON.stringify(params)}</span> | ||
</h3> | ||
{children} | ||
</> | ||
) | ||
} |
13 changes: 13 additions & 0 deletions
13
test/e2e/app-dir/app/app/dynamic-client/[category]/[id]/page.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
'use client' | ||
|
||
export default function IdPage({ children, params }) { | ||
return ( | ||
<> | ||
<p> | ||
Id Page. Params:{' '} | ||
<span id="id-page-params">{JSON.stringify(params)}</span> | ||
</p> | ||
{children} | ||
</> | ||
) | ||
} |
11 changes: 11 additions & 0 deletions
11
test/e2e/app-dir/app/app/dynamic-client/[category]/layout.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
export default function CategoryLayout({ children, params }) { | ||
return ( | ||
<> | ||
<h2> | ||
Category Layout. Params:{' '} | ||
<span id="category-layout-params">{JSON.stringify(params)}</span>{' '} | ||
</h2> | ||
{children} | ||
</> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
export default function DynamicLayout({ children, params }) { | ||
return ( | ||
<> | ||
<h1> | ||
Dynamic Layout. Params:{' '} | ||
<span id="dynamic-layout-params">{JSON.stringify(params)}</span> | ||
</h1> | ||
{children} | ||
</> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters