Encode URL paths in HTML and CSR #8435

eshikerya · 2019-08-20T06:11:25Z

/page/[id].js now encoded to /page/%5Bid%5D.js

eshikerya · 2019-08-20T06:11:55Z

Timer

Great! We still need to update page-loader as mentioned in the linked issue. Also, shouldn't we use encodeURI or encodeURIComponent instead of a custom method?

eshikerya · 2019-08-20T06:21:39Z

encodeURI will encode everything, we care about [ ] symbols only. that's why custom method. As I see from code, the file name could contain a part of the path, so standard methods doesn't work...
oops, missed page-loader, will dig more...

Timer · 2019-08-20T06:23:53Z

Seems pretty desirable:

encodeURI('testing/this/_fileName/[bla].js')
"testing/this/_fileName/%5Bbla%5D.js"

eshikerya · 2019-08-20T06:32:52Z

yes, good catch, almost 24 hours w/o sleep, "my mind is glowing" :)

Timer · 2019-08-20T06:39:19Z

Get some rest, @eshikerya! I'm about to sleep myself. 😄

… into filename-encoder

eshikerya · 2019-08-20T06:57:53Z

this issue blocks me to release, so have to fight it down:)

packages/next/pages/_document.tsx

eshikerya · 2019-08-21T04:36:01Z

@Timer, any estimate when it going to be merged and released?

timneutkens · 2019-08-21T11:44:19Z

@eshikerya considering there are merge conflicts and the tests are not passing the PR is currently not in a mergeable state.

Timer · 2019-08-22T14:03:13Z

Did you test manually if this fixes the deployment/behavior?

ijjk · 2019-08-22T14:05:53Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	26.6s	27s	⚠️ +341ms
nodeModulesSize	41.2 MB	41.3 MB	⚠️ +46.2 kB

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	17.8 kB	17.9 kB	⚠️ +129 B
main-HASH.js gzip	6.54 kB	6.57 kB	⚠️ +27 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			⚠️ +129 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.1 kB	16.2 kB	⚠️ +83 B
main-HASH.module.js gzip	6.27 kB	6.28 kB	⚠️ +10 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			⚠️ +83 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Fetched pages Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
link	2.78 kB	2.81 kB	⚠️ +30 B
link gzip	836 B	858 B	⚠️ +22 B
index	2.73 kB	2.76 kB	⚠️ +30 B
index gzip	827 B	850 B	⚠️ +23 B
withRouter	2.79 kB	2.82 kB	⚠️ +30 B
withRouter gzip	824 B	844 B	⚠️ +20 B
Overall change			⚠️ +90 B

Diffs

Diff for main-HASH.js

@@ -343,6 +343,7 @@ var props = data.props,
     page = data.page,
     query = data.query,
     buildId = data.buildId,
+    dynamicBuildId = data.dynamicBuildId,
     assetPrefix = data.assetPrefix,
     runtimeConfig = data.runtimeConfig,
     dynamicIds = data.dynamicIds;
@@ -515,6 +516,8 @@ function () {
             return window.__NEXT_PRELOADREADY(dynamicIds);
 
           case 22:
+            if (false) {}
+
             exports.router = router = (0, _router.createRouter)(page, query, asPath, {
               initialProps: props,
               pageLoader: pageLoader,
@@ -545,7 +548,7 @@ function () {
             render(renderCtx);
             return _context.abrupt("return", emitter);
 
-          case 26:
+          case 27:
           case "end":
             return _context.stop();
         }
@@ -1423,7 +1426,7 @@ function preloadScript(url) {
   var link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1432,6 +1435,8 @@ var PageLoader =
 /*#__PURE__*/
 function () {
   function PageLoader(buildId, assetPrefix) {
+    var _this3 = this;
+
     _classCallCheck(this, PageLoader);
 
     this.buildId = buildId;
@@ -1439,6 +1444,9 @@ function () {
     this.pageCache = {};
     this.pageRegisterEvents = (0, _mitt["default"])();
     this.loadingRoutes = {};
+    this.promisedBuildId = _promise["default"].resolve();
+
+    if (false) {}
 
     if (false) {}
   } // Returns a promise for the dependencies for a particular route
@@ -1467,7 +1475,7 @@ function () {
   }, {
     key: "loadPage",
     value: function loadPage(route) {
-      var _this3 = this;
+      var _this4 = this;
 
       route = this.normalizeRoute(route);
       return new _promise["default"](function (resolve, reject) {
@@ -1475,9 +1483,9 @@ function () {
           var error = _ref.error,
               page = _ref.page;
 
-          _this3.pageRegisterEvents.off(route, fire);
+          _this4.pageRegisterEvents.off(route, fire);
 
-          delete _this3.loadingRoutes[route];
+          delete _this4.loadingRoutes[route];
 
           if (error) {
             reject(error);
@@ -1487,7 +1495,7 @@ function () {
         }; // If there's a cached version of the page, let's use it.
 
 
-        var cachedPage = _this3.pageCache[route];
+        var cachedPage = _this4.pageCache[route];
 
         if (cachedPage) {
           var error = cachedPage.error,
@@ -1497,7 +1505,7 @@ function () {
         } // Register a listener to get the page
 
 
-        _this3.pageRegisterEvents.on(route, fire); // If the page is loading via SSR, we need to wait for it
+        _this4.pageRegisterEvents.on(route, fire); // If the page is loading via SSR, we need to wait for it
         // rather downloading it again.
 
 
@@ -1505,11 +1513,11 @@ function () {
           return;
         }
 
-        if (!_this3.loadingRoutes[route]) {
+        if (!_this4.loadingRoutes[route]) {
           if (false) {} else {
-            _this3.loadRoute(route);
+            _this4.loadRoute(route);
 
-            _this3.loadingRoutes[route] = true;
+            _this4.loadingRoutes[route] = true;
           }
         }
       });
@@ -1527,13 +1535,22 @@ function () {
           while (1) {
             switch (_context.prev = _context.next) {
               case 0:
+                if (true) {
+                  _context.next = 3;
+                  break;
+                }
+
+                _context.next = 3;
+                return _this.promisedBuildId;
+
+              case 3:
                 route = _this.normalizeRoute(route);
                 scriptRoute = route === '/' ? '/index.js' : route + ".js";
                 url = _this.assetPrefix + "/_next/static/" + encodeURIComponent(_this.buildId) + "/pages" + scriptRoute;
 
                 _this.loadScript(url, route, true);
 
-              case 4:
+              case 7:
               case "end":
                 return _context.stop();
             }
@@ -1544,7 +1561,7 @@ function () {
   }, {
     key: "loadScript",
     value: function loadScript(url, route, isPage) {
-      var _this4 = this;
+      var _this5 = this;
 
       var script = document.createElement('script');
 
@@ -1556,13 +1573,13 @@ function () {
       }
 
       script.crossOrigin = "anonymous";
-      script.src = url;
+      script.src = encodeURI(url);
 
       script.onerror = function () {
         var error = new Error("Error loading script " + url);
         error.code = 'PAGE_LOAD_ERROR';
 
-        _this4.pageRegisterEvents.emit(route, {
+        _this5.pageRegisterEvents.emit(route, {
           error: error
         });
       };
@@ -1573,7 +1590,7 @@ function () {
   }, {
     key: "registerPage",
     value: function registerPage(route, regFn) {
-      var _this5 = this;
+      var _this6 = this;
 
       var register = function register() {
         try {
@@ -1581,21 +1598,21 @@ function () {
               error = _regFn.error,
               page = _regFn.page;
 
-          _this5.pageCache[route] = {
+          _this6.pageCache[route] = {
             error: error,
             page: page
           };
 
-          _this5.pageRegisterEvents.emit(route, {
+          _this6.pageRegisterEvents.emit(route, {
             error: error,
             page: page
           });
         } catch (error) {
-          _this5.pageCache[route] = {
+          _this6.pageCache[route] = {
             error: error
           };
 
-          _this5.pageRegisterEvents.emit(route, {
+          _this6.pageRegisterEvents.emit(route, {
             error: error
           });
         }
@@ -1618,6 +1635,15 @@ function () {
           while (1) {
             switch (_context2.prev = _context2.next) {
               case 0:
+                if (true) {
+                  _context2.next = 3;
+                  break;
+                }
+
+                _context2.next = 3;
+                return _this2.promisedBuildId;
+
+              case 3:
                 route = _this2.normalizeRoute(route);
                 scriptRoute = (route === '/' ? '/index' : route) + ".js";
 
@@ -1629,68 +1655,68 @@ function () {
                 // its own deduping mechanism.
 
                 if (!document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {
-                  _context2.next = 6;
+                  _context2.next = 9;
                   break;
                 }
 
                 return _context2.abrupt("return");
 
-              case 6:
+              case 9:
                 if (!(cn = navigator.connection)) {
-                  _context2.next = 9;
+                  _context2.next = 12;
                   break;
                 }
 
                 if (!((cn.effectiveType || '').indexOf('2g') !== -1 || cn.saveData)) {
-                  _context2.next = 9;
+                  _context2.next = 12;
                   break;
                 }
 
                 return _context2.abrupt("return");
 
-              case 9:
+              case 12:
                 if (true) {
-                  _context2.next = 15;
+                  _context2.next = 18;
                   break;
                 }
 
                 ;
-                _context2.next = 13;
+                _context2.next = 16;
                 return _this2.getDependencies(route);
 
-              case 13:
+              case 16:
                 _context2.t0 = function (url) {
                   _this2.prefetch(url, true);
                 };
 
                 _context2.sent.forEach(_context2.t0);
 
-              case 15:
+              case 18:
                 if (!hasPreload) {
-                  _context2.next = 18;
+                  _context2.next = 21;
                   break;
                 }
 
                 preloadScript(url);
                 return _context2.abrupt("return");
 
-              case 18:
+              case 21:
                 if (!isDependency) {
-                  _context2.next = 20;
+                  _context2.next = 23;
                   break;
                 }
 
                 return _context2.abrupt("return");
 
-              case 20:
+              case 23:
                 if (!(document.readyState === 'complete')) {
-                  _context2.next = 24;
+                  _context2.next = 27;
                   break;
                 }
 
                 return _context2.abrupt("return", _this2.loadPage(route)["catch"](function () {}));
 
-              case 24:
+              case 27:
                 return _context2.abrupt("return", new _promise["default"](function (resolve) {
                   window.addEventListener('load', function () {
                     _this2.loadPage(route).then(function () {
@@ -1701,7 +1727,7 @@ function () {
                   });
                 }));
 
-              case 25:
+              case 28:
               case "end":
                 return _context2.stop();
             }

Diff for main-HASH.module.js

@@ -416,6 +416,7 @@ const {
   page,
   query,
   buildId,
+  dynamicBuildId,
   assetPrefix,
   runtimeConfig,
   dynamicIds
@@ -530,6 +531,8 @@ function () {
       yield window.__NEXT_PRELOADREADY(dynamicIds);
     }
 
+    if (false) {}
+
     exports.router = router = (0, _router.createRouter)(page, query, asPath, {
       initialProps: props,
       pageLoader,
@@ -1336,7 +1339,7 @@ function preloadScript(url) {
   const link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1348,6 +1351,9 @@ class PageLoader {
     this.pageCache = {};
     this.pageRegisterEvents = (0, _mitt.default)();
     this.loadingRoutes = {};
+    this.promisedBuildId = _promise.default.resolve();
+
+    if (false) {}
 
     if (false) {}
   } // Returns a promise for the dependencies for a particular route
@@ -1418,6 +1424,8 @@ class PageLoader {
     var _this = this;
 
     return (0, _asyncToGenerator2.default)(function* () {
+      if (false) {}
+
       route = _this.normalizeRoute(route);
       let scriptRoute = route === '/' ? '/index.js' : route + ".js";
       const url = _this.assetPrefix + "/_next/static/" + encodeURIComponent(_this.buildId) + "/pages" + scriptRoute;
@@ -1437,7 +1445,7 @@ class PageLoader {
     }
 
     script.crossOrigin = "anonymous";
-    script.src = url;
+    script.src = encodeURI(url);
 
     script.onerror = () => {
       const error = new Error("Error loading script " + url);
@@ -1485,6 +1493,8 @@ class PageLoader {
     var _this2 = this;
 
     return (0, _asyncToGenerator2.default)(function* () {
+      if (false) {}
+
       route = _this2.normalizeRoute(route);
       let scriptRoute = (route === '/' ? '/index' : route) + ".js";

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	28.6s	28.9s	⚠️ +287ms
nodeModulesSize	41.2 MB	41.3 MB	⚠️ +46.2 kB

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	17.8 kB	17.9 kB	⚠️ +129 B
main-HASH.js gzip	6.54 kB	6.57 kB	⚠️ +27 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			⚠️ +129 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.1 kB	16.2 kB	⚠️ +83 B
main-HASH.module.js gzip	6.27 kB	6.28 kB	⚠️ +10 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			⚠️ +83 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_error.js	246 kB	247 kB	⚠️ +844 B
_error.js gzip	66.2 kB	66.3 kB	⚠️ +96 B
hooks.html	2.85 kB	2.88 kB	⚠️ +30 B
hooks.html gzip	852 B	872 B	⚠️ +20 B
index.js	247 kB	248 kB	⚠️ +789 B
index.js gzip	66.4 kB	66.6 kB	⚠️ +217 B
link.js	255 kB	255 kB	⚠️ +789 B
link.js gzip	68.6 kB	68.8 kB	⚠️ +166 B
routerDirect.js	248 kB	248 kB	⚠️ +789 B
routerDirect.js gzip	66.6 kB	66.5 kB	-22 B
withRouter.js	248 kB	248 kB	⚠️ +789 B
withRouter.js gzip	66.6 kB	66.6 kB	⚠️ +77 B
Overall change			⚠️ +4.03 kB

eshikerya · 2019-08-22T14:07:16Z

I tested it locally and it work as expected. also tested the behavior of different web servers, how they processing the case when filesystem contain file like [id].js but request is encoded - all green

ijjk · 2019-08-22T14:09:25Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	23.4s	23s	-325ms
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +302 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +22 B
main-HASH.js gzip	6.63 kB	6.63 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	908 B	908 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	867 B	867 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Fetched pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
link	3.75 kB	3.75 kB	✓
link gzip	965 B	961 B	-4 B
index	3.69 kB	3.69 kB	✓
index gzip	956 B	952 B	-4 B
withRouter	3.75 kB	3.75 kB	✓
withRouter gzip	951 B	948 B	-3 B
Overall change			✓

Diffs

Diff for main-HASH.js

@@ -1423,7 +1423,7 @@ function preloadScript(url) {
   var link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1574,7 +1574,7 @@ function () {
       }
 
       script.crossOrigin = "anonymous";
-      script.src = url;
+      script.src = encodeURI(url);
 
       script.onerror = function () {
         var error = new Error("Error loading script " + url);

Diff for main-HASH.module.js

@@ -1336,7 +1336,7 @@ function preloadScript(url) {
   const link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1454,7 +1454,7 @@ class PageLoader {
     }
 
     script.crossOrigin = "anonymous";
-    script.src = url;
+    script.src = encodeURI(url);
 
     script.onerror = () => {
       const error = new Error("Error loading script " + url);

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	25.5s	25.5s	-22ms
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +302 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +21 B
main-HASH.js gzip	6.63 kB	6.63 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +21 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +21 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +2 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +21 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	908 B	908 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	⚠️ +1 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	433 B	434 B	⚠️ +1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			⚠️ +1 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	867 B	866 B	-1 B
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	805 B	⚠️ +1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	430 B	⚠️ +1 B
withRouter.module.js gzip	293 B	293 B	✓
Overall change			⚠️ +1 B

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_error.js	248 kB	248 kB	⚠️ +64 B
_error.js gzip	66.5 kB	66.4 kB	-26 B
hooks.html	3.81 kB	3.81 kB	-5 B
hooks.html gzip	979 B	978 B	-1 B
index.js	248 kB	248 kB	⚠️ +64 B
index.js gzip	66.6 kB	66.6 kB	-62 B
link.js	256 kB	256 kB	⚠️ +64 B
link.js gzip	68.9 kB	68.8 kB	-17 B
routerDirect.js	249 kB	249 kB	⚠️ +64 B
routerDirect.js gzip	66.8 kB	66.7 kB	-172 B
withRouter.js	249 kB	249 kB	⚠️ +64 B
withRouter.js gzip	66.9 kB	66.8 kB	-67 B
Overall change			⚠️ +315 B

ijjk · 2019-08-22T14:09:26Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	23.6s	23.1s	-428ms
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +302 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +22 B
main-HASH.js gzip	6.63 kB	6.63 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	908 B	908 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	867 B	867 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Fetched pages Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
link	3.74 kB	3.74 kB	⚠️ +2 B
link gzip	958 B	964 B	⚠️ +6 B
index	3.69 kB	3.69 kB	⚠️ +2 B
index gzip	950 B	955 B	⚠️ +5 B
withRouter	3.75 kB	3.75 kB	⚠️ +2 B
withRouter gzip	945 B	950 B	⚠️ +5 B
Overall change			⚠️ +6 B

Diffs

Diff for main-HASH.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1423,7 +1423,7 @@ function preloadScript(url) {
   var link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1574,7 +1574,7 @@ function () {
       }
 
       script.crossOrigin = "anonymous";
-      script.src = url;
+      script.src = encodeURI(url);
 
       script.onerror = function () {
         var error = new Error("Error loading script " + url);

Diff for main-HASH.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1336,7 +1336,7 @@ function preloadScript(url) {
   const link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1454,7 +1454,7 @@ class PageLoader {
     }
 
     script.crossOrigin = "anonymous";
-    script.src = url;
+    script.src = encodeURI(url);
 
     script.onerror = () => {
       const error = new Error("Error loading script " + url);

Diff for _app.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for _app.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	24.6s	24.8s	⚠️ +246ms
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +302 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +23 B
main-HASH.js gzip	6.62 kB	6.63 kB	⚠️ +6 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +23 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +23 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +4 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +23 B

Client Pages Overall decrease ✓

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	908 B	908 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	-1 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	-1 B
routerDirect.js	434 B	433 B	-1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			-1 B

Client Pages Modern Overall decrease ✓

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	866 B	867 B	⚠️ +1 B
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	805 B	804 B	-1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	430 B	429 B	-1 B
withRouter.module.js gzip	293 B	293 B	✓
Overall change			-1 B

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_error.js	248 kB	248 kB	⚠️ +66 B
_error.js gzip	66.4 kB	66.5 kB	⚠️ +72 B
hooks.html	3.81 kB	3.81 kB	-6 B
hooks.html gzip	979 B	979 B	✓
index.js	248 kB	248 kB	⚠️ +61 B
index.js gzip	66.7 kB	66.7 kB	-60 B
link.js	256 kB	256 kB	⚠️ +61 B
link.js gzip	68.8 kB	68.8 kB	-47 B
routerDirect.js	249 kB	249 kB	⚠️ +61 B
routerDirect.js gzip	66.7 kB	66.7 kB	⚠️ +34 B
withRouter.js	249 kB	249 kB	⚠️ +61 B
withRouter.js gzip	66.9 kB	66.7 kB	-149 B
Overall change			⚠️ +304 B

ijjk · 2019-08-23T09:56:16Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	23.6s	23.3s	-238ms
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +302 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +22 B
main-HASH.js gzip	6.63 kB	6.63 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Fetched pages Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
link	3.74 kB	3.75 kB	⚠️ +1 B
link gzip	957 B	965 B	⚠️ +8 B
index	3.69 kB	3.69 kB	⚠️ +1 B
index gzip	950 B	955 B	⚠️ +5 B
withRouter	3.75 kB	3.75 kB	⚠️ +1 B
withRouter gzip	944 B	951 B	⚠️ +7 B
Overall change			⚠️ +3 B

Diffs

Diff for main-HASH.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1423,7 +1423,7 @@ function preloadScript(url) {
   var link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1574,7 +1574,7 @@ function () {
       }
 
       script.crossOrigin = "anonymous";
-      script.src = url;
+      script.src = encodeURI(url);
 
       script.onerror = function () {
         var error = new Error("Error loading script " + url);

Diff for main-HASH.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1336,7 +1336,7 @@ function preloadScript(url) {
   const link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1454,7 +1454,7 @@ class PageLoader {
     }
 
     script.crossOrigin = "anonymous";
-    script.src = url;
+    script.src = encodeURI(url);
 
     script.onerror = () => {
       const error = new Error("Error loading script " + url);

Diff for _app.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for _app.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	25.1s	24.9s	-125ms
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +302 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +22 B
main-HASH.js gzip	6.63 kB	6.63 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_error.js	247 kB	247 kB	⚠️ +85 B
_error.js gzip	66.4 kB	66.2 kB	-152 B
hooks.html	3.81 kB	3.81 kB	⚠️ +2 B
hooks.html gzip	974 B	979 B	⚠️ +5 B
index.js	248 kB	248 kB	⚠️ +80 B
index.js gzip	66.6 kB	66.7 kB	⚠️ +130 B
link.js	255 kB	255 kB	⚠️ +80 B
link.js gzip	68.7 kB	68.9 kB	⚠️ +168 B
routerDirect.js	249 kB	249 kB	⚠️ +80 B
routerDirect.js gzip	66.6 kB	66.9 kB	⚠️ +254 B
withRouter.js	248 kB	249 kB	⚠️ +80 B
withRouter.js gzip	66.7 kB	66.6 kB	-40 B
Overall change			⚠️ +407 B

packages/next/pages/_document.tsx

Co-Authored-By: Joe Haddad <[email protected]>

ijjk · 2019-08-23T17:46:24Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	20.6s	20.9s	⚠️ +393ms
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +1.17 kB

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +22 B
main-HASH.js gzip	6.63 kB	6.63 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Diffs

Diff for main-HASH.js

@@ -1423,7 +1423,7 @@ function preloadScript(url) {
   var link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1574,7 +1574,7 @@ function () {
       }
 
       script.crossOrigin = "anonymous";
-      script.src = url;
+      script.src = encodeURI(url);
 
       script.onerror = function () {
         var error = new Error("Error loading script " + url);

Diff for main-HASH.module.js

@@ -1336,7 +1336,7 @@ function preloadScript(url) {
   const link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1454,7 +1454,7 @@ class PageLoader {
     }
 
     script.crossOrigin = "anonymous";
-    script.src = url;
+    script.src = encodeURI(url);
 
     script.onerror = () => {
       const error = new Error("Error loading script " + url);

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	22.1s	21.3s	-770ms
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +1.17 kB

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +22 B
main-HASH.js gzip	6.63 kB	6.63 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_error.js	247 kB	247 kB	⚠️ +66 B
_error.js gzip	66.3 kB	66.3 kB	-19 B
hooks.html	3.81 kB	3.81 kB	-5 B
hooks.html gzip	980 B	979 B	-1 B
index.js	248 kB	248 kB	⚠️ +66 B
index.js gzip	66.6 kB	66.8 kB	⚠️ +206 B
link.js	255 kB	255 kB	⚠️ +66 B
link.js gzip	68.9 kB	68.9 kB	⚠️ +13 B
routerDirect.js	249 kB	249 kB	⚠️ +66 B
routerDirect.js gzip	66.6 kB	66.8 kB	⚠️ +204 B
withRouter.js	248 kB	249 kB	⚠️ +66 B
withRouter.js gzip	66.7 kB	66.7 kB	⚠️ +52 B
Overall change			⚠️ +325 B

ijjk · 2019-08-23T17:59:40Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	23.8s	24.2s	⚠️ +423ms
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +1.27 kB

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +22 B
main-HASH.js gzip	6.63 kB	6.63 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Diffs

Diff for main-HASH.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1423,7 +1423,7 @@ function preloadScript(url) {
   var link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1574,7 +1574,7 @@ function () {
       }
 
       script.crossOrigin = "anonymous";
-      script.src = url;
+      script.src = encodeURI(url);
 
       script.onerror = function () {
         var error = new Error("Error loading script " + url);

Diff for main-HASH.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
@@ -1336,7 +1336,7 @@ function preloadScript(url) {
   const link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1454,7 +1454,7 @@ class PageLoader {
     }
 
     script.crossOrigin = "anonymous";
-    script.src = url;
+    script.src = encodeURI(url);
 
     script.onerror = () => {
       const error = new Error("Error loading script " + url);

Diff for _app.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for _app.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	26.2s	27.5s	⚠️ +1.3s
nodeModulesSize	41.2 MB	41.2 MB	⚠️ +1.27 kB

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.1 kB	⚠️ +22 B
main-HASH.js gzip	6.63 kB	6.63 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.36 kB	6.36 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_error.js	247 kB	247 kB	⚠️ +92 B
_error.js gzip	66.3 kB	66.3 kB	-17 B
hooks.html	3.81 kB	3.81 kB	-6 B
hooks.html gzip	980 B	980 B	✓
index.js	248 kB	248 kB	⚠️ +92 B
index.js gzip	66.7 kB	66.6 kB	-105 B
link.js	255 kB	255 kB	⚠️ +92 B
link.js gzip	68.8 kB	68.9 kB	⚠️ +105 B
routerDirect.js	249 kB	249 kB	⚠️ +92 B
routerDirect.js gzip	66.7 kB	66.8 kB	⚠️ +101 B
withRouter.js	248 kB	249 kB	⚠️ +92 B
withRouter.js gzip	66.7 kB	66.7 kB	⚠️ +54 B
Overall change			⚠️ +454 B

eshikerya · 2019-08-29T14:54:29Z

@Timer FYI: im using this fix on my production env and confirm everything is working as expected

Timer

Thank you for fixing this!

ijjk · 2019-08-29T16:42:13Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	23.6s	23.6s	-33ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +402 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.2 kB	⚠️ +21 B
main-HASH.js gzip	6.64 kB	6.64 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +21 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +21 B
main-HASH.module.js gzip	6.37 kB	6.37 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +21 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	⚠️ +1 B
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	433 B	434 B	⚠️ +1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			⚠️ +1 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	805 B	⚠️ +1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	430 B	⚠️ +1 B
withRouter.module.js gzip	293 B	293 B	✓
Overall change			⚠️ +1 B

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Rendered Page Sizes

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
index.html	3.7 kB	3.7 kB	✓
index.html gzip	955 B	956 B	⚠️ +1 B
link.html	3.75 kB	3.75 kB	✓
link.html gzip	963 B	964 B	⚠️ +1 B
withRouter.html	3.75 kB	3.75 kB	✓
withRouter.html gzip	951 B	951 B	✓
Overall change			✓

Diffs

Diff for main-HASH.js

@@ -1425,7 +1425,7 @@ function preloadScript(url) {
   var link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1576,7 +1576,7 @@ function () {
       }
 
       script.crossOrigin = "anonymous";
-      script.src = url;
+      script.src = encodeURI(url);
 
       script.onerror = function () {
         var error = new Error("Error loading script " + url);

Diff for main-HASH.module.js

@@ -1338,7 +1338,7 @@ function preloadScript(url) {
   const link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1456,7 +1456,7 @@ class PageLoader {
     }
 
     script.crossOrigin = "anonymous";
-    script.src = url;
+    script.src = encodeURI(url);
 
     script.onerror = () => {
       const error = new Error("Error loading script " + url);

Diff for index.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/index.module.js"
+        <link rel="preload" href="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/op3Rt18VsYlmn9j7ZjI4Ee4LFvo=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/XUr3gp4dI+tXbCBL95ukvJu18jE=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/9hEqvHXrbfeFeQzekfLFf/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/oYc5mjlb_MV7NnSxCx7ta/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,40 +26,40 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"9hEqvHXrbfeFeQzekfLFf"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"oYc5mjlb_MV7NnSxCx7ta"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
+        <script src="/_next/static/runtime/main-2cd30e118423b74fdb03.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <script src="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/GpMu3zh9rmkXBH8g5zPqrG4g1E=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/HtAijMZTqGAeFbKGEUN7fF7imc=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/op3Rt18VsYlmn9j7ZjI4Ee4LFvo=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/XUr3gp4dI+tXbCBL95ukvJu18jE=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/op3Rt18VsYlmn9j7ZjI4Ee4LFvo=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/XUr3gp4dI+tXbCBL95ukvJu18jE=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/9hEqvHXrbfeFeQzekfLFf/_buildManifest.js"
+        <script src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/9hEqvHXrbfeFeQzekfLFf/_buildManifest.module.js"
+        <script src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for link.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/link.module.js"
+        <link rel="preload" href="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/op3Rt18VsYlmn9j7ZjI4Ee4LFvo=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/XUr3gp4dI+tXbCBL95ukvJu18jE=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/9hEqvHXrbfeFeQzekfLFf/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/oYc5mjlb_MV7NnSxCx7ta/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"9hEqvHXrbfeFeQzekfLFf"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"oYc5mjlb_MV7NnSxCx7ta"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/GpMu3zh9rmkXBH8g5zPqrG4g1E=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/HtAijMZTqGAeFbKGEUN7fF7imc=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/op3Rt18VsYlmn9j7ZjI4Ee4LFvo=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/XUr3gp4dI+tXbCBL95ukvJu18jE=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/op3Rt18VsYlmn9j7ZjI4Ee4LFvo=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/XUr3gp4dI+tXbCBL95ukvJu18jE=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
+        <script src="/_next/static/runtime/main-2cd30e118423b74fdb03.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <script src="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/9hEqvHXrbfeFeQzekfLFf/_buildManifest.js"
+        <script src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/9hEqvHXrbfeFeQzekfLFf/_buildManifest.module.js"
+        <script src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for withRouter.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/op3Rt18VsYlmn9j7ZjI4Ee4LFvo=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/XUr3gp4dI+tXbCBL95ukvJu18jE=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/9hEqvHXrbfeFeQzekfLFf/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/oYc5mjlb_MV7NnSxCx7ta/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"9hEqvHXrbfeFeQzekfLFf"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"oYc5mjlb_MV7NnSxCx7ta"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/9hEqvHXrbfeFeQzekfLFf/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/GpMu3zh9rmkXBH8g5zPqrG4g1E=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/HtAijMZTqGAeFbKGEUN7fF7imc=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/op3Rt18VsYlmn9j7ZjI4Ee4LFvo=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/XUr3gp4dI+tXbCBL95ukvJu18jE=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/op3Rt18VsYlmn9j7ZjI4Ee4LFvo=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/XUr3gp4dI+tXbCBL95ukvJu18jE=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
+        <script src="/_next/static/runtime/main-2cd30e118423b74fdb03.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <script src="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/9hEqvHXrbfeFeQzekfLFf/_buildManifest.js"
+        <script src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/9hEqvHXrbfeFeQzekfLFf/_buildManifest.module.js"
+        <script src="/_next/static/oYc5mjlb_MV7NnSxCx7ta/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	24.6s	24.4s	-193ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +402 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.2 kB	⚠️ +22 B
main-HASH.js gzip	6.64 kB	6.64 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.37 kB	6.38 kB	⚠️ +4 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_error.js	247 kB	247 kB	⚠️ +124 B
_error.js gzip	66.3 kB	66.4 kB	⚠️ +138 B
hooks.html	3.81 kB	3.81 kB	⚠️ +6 B
hooks.html gzip	980 B	976 B	-4 B
index.js	248 kB	248 kB	⚠️ +124 B
index.js gzip	66.6 kB	66.6 kB	⚠️ +69 B
link.js	255 kB	255 kB	⚠️ +124 B
link.js gzip	68.9 kB	68.9 kB	⚠️ +32 B
routerDirect.js	249 kB	249 kB	⚠️ +124 B
routerDirect.js gzip	66.9 kB	66.7 kB	-165 B
withRouter.js	248 kB	249 kB	⚠️ +124 B
withRouter.js gzip	66.8 kB	66.7 kB	-170 B
Overall change			⚠️ +626 B

ijjk · 2019-08-29T16:52:42Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	24.8s	24.7s	-52ms
nodeModulesSize	41.8 MB	41.8 MB	⚠️ +402 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.2 kB	⚠️ +22 B
main-HASH.js gzip	6.64 kB	6.64 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.37 kB	6.38 kB	⚠️ +4 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Rendered Page Sizes

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
index.html	3.7 kB	3.7 kB	✓
index.html gzip	954 B	955 B	⚠️ +1 B
link.html	3.75 kB	3.75 kB	✓
link.html gzip	962 B	964 B	⚠️ +2 B
withRouter.html	3.75 kB	3.75 kB	✓
withRouter.html gzip	949 B	951 B	⚠️ +2 B
Overall change			✓

Diffs

Diff for main-HASH.js

@@ -1425,7 +1425,7 @@ function preloadScript(url) {
   var link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1576,7 +1576,7 @@ function () {
       }
 
       script.crossOrigin = "anonymous";
-      script.src = url;
+      script.src = encodeURI(url);
 
       script.onerror = function () {
         var error = new Error("Error loading script " + url);

Diff for main-HASH.module.js

@@ -1338,7 +1338,7 @@ function preloadScript(url) {
   const link = document.createElement('link');
   link.rel = 'preload';
   link.crossOrigin = "anonymous";
-  link.href = url;
+  link.href = encodeURI(url);
   link.as = 'script';
   document.head.appendChild(link);
 }
@@ -1456,7 +1456,7 @@ class PageLoader {
     }
 
     script.crossOrigin = "anonymous";
-    script.src = url;
+    script.src = encodeURI(url);
 
     script.onerror = () => {
       const error = new Error("Error loading script " + url);

Diff for index.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/index.module.js"
+        <link rel="preload" href="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/MCioONLz7X4kq+nldqdAqe3Hkqc=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/7jnv6Rq3ycpbjmj2jUmBOfm8k=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/flmXAqJe_NpqNm6R8LWoH/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/OrI76QhEECJvqz4w1sA-F/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,40 +26,40 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"flmXAqJe_NpqNm6R8LWoH"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"OrI76QhEECJvqz4w1sA-F"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
+        <script src="/_next/static/runtime/main-2cd30e118423b74fdb03.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <script src="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/Iwvw+XVGj+MgXYcmiHKC2YOKZ0=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/uYE+lrxMC2OqtmH+BkuWedzBCC8=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/MCioONLz7X4kq+nldqdAqe3Hkqc=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/7jnv6Rq3ycpbjmj2jUmBOfm8k=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/MCioONLz7X4kq+nldqdAqe3Hkqc=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/7jnv6Rq3ycpbjmj2jUmBOfm8k=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/flmXAqJe_NpqNm6R8LWoH/_buildManifest.js"
+        <script src="/_next/static/OrI76QhEECJvqz4w1sA-F/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/flmXAqJe_NpqNm6R8LWoH/_buildManifest.module.js"
+        <script src="/_next/static/OrI76QhEECJvqz4w1sA-F/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for link.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/link.module.js"
+        <link rel="preload" href="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/MCioONLz7X4kq+nldqdAqe3Hkqc=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/7jnv6Rq3ycpbjmj2jUmBOfm8k=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/flmXAqJe_NpqNm6R8LWoH/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/OrI76QhEECJvqz4w1sA-F/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"flmXAqJe_NpqNm6R8LWoH"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"OrI76QhEECJvqz4w1sA-F"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/Iwvw+XVGj+MgXYcmiHKC2YOKZ0=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/uYE+lrxMC2OqtmH+BkuWedzBCC8=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/MCioONLz7X4kq+nldqdAqe3Hkqc=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/7jnv6Rq3ycpbjmj2jUmBOfm8k=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/MCioONLz7X4kq+nldqdAqe3Hkqc=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/7jnv6Rq3ycpbjmj2jUmBOfm8k=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
+        <script src="/_next/static/runtime/main-2cd30e118423b74fdb03.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <script src="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/flmXAqJe_NpqNm6R8LWoH/_buildManifest.js"
+        <script src="/_next/static/OrI76QhEECJvqz4w1sA-F/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/flmXAqJe_NpqNm6R8LWoH/_buildManifest.module.js"
+        <script src="/_next/static/OrI76QhEECJvqz4w1sA-F/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for withRouter.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/MCioONLz7X4kq+nldqdAqe3Hkqc=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/7jnv6Rq3ycpbjmj2jUmBOfm8k=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/flmXAqJe_NpqNm6R8LWoH/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/OrI76QhEECJvqz4w1sA-F/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"flmXAqJe_NpqNm6R8LWoH"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"OrI76QhEECJvqz4w1sA-F"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/flmXAqJe_NpqNm6R8LWoH/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/OrI76QhEECJvqz4w1sA-F/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/Iwvw+XVGj+MgXYcmiHKC2YOKZ0=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/uYE+lrxMC2OqtmH+BkuWedzBCC8=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/MCioONLz7X4kq+nldqdAqe3Hkqc=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/7jnv6Rq3ycpbjmj2jUmBOfm8k=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/MCioONLz7X4kq+nldqdAqe3Hkqc=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/7jnv6Rq3ycpbjmj2jUmBOfm8k=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
+        <script src="/_next/static/runtime/main-2cd30e118423b74fdb03.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <script src="/_next/static/runtime/main-b34dfc4fd33bc7bccca0.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/flmXAqJe_NpqNm6R8LWoH/_buildManifest.js"
+        <script src="/_next/static/OrI76QhEECJvqz4w1sA-F/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/flmXAqJe_NpqNm6R8LWoH/_buildManifest.module.js"
+        <script src="/_next/static/OrI76QhEECJvqz4w1sA-F/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
buildDuration	25.7s	26.1s	⚠️ +354ms
nodeModulesSize	41.8 MB	41.8 MB	⚠️ +402 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.js	18.1 kB	18.2 kB	⚠️ +22 B
main-HASH.js gzip	6.64 kB	6.64 kB	⚠️ +5 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
main-HASH.module.js	16.5 kB	16.5 kB	⚠️ +22 B
main-HASH.module.js gzip	6.37 kB	6.38 kB	⚠️ +4 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
Overall change			⚠️ +22 B

Client Pages

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	884 B	884 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	840 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.62 kB	8.62 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect.module.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.module.js gzip	293 B	293 B	✓
Overall change			✓

Client Build Manifests

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManifest.module.js gzip	61 B	61 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	eshikerya/next.js filename-encoder	Change
_error.js	247 kB	247 kB	⚠️ +103 B
_error.js gzip	66.2 kB	66.3 kB	⚠️ +87 B
hooks.html	3.81 kB	3.81 kB	-1 B
hooks.html gzip	978 B	979 B	⚠️ +1 B
index.js	248 kB	248 kB	⚠️ +103 B
index.js gzip	66.6 kB	66.6 kB	⚠️ +43 B
link.js	255 kB	255 kB	⚠️ +103 B
link.js gzip	68.9 kB	68.9 kB	⚠️ +21 B
routerDirect.js	249 kB	249 kB	⚠️ +103 B
routerDirect.js gzip	66.6 kB	66.9 kB	⚠️ +246 B
withRouter.js	248 kB	249 kB	⚠️ +103 B
withRouter.js gzip	66.8 kB	66.6 kB	-113 B
Overall change			⚠️ +514 B

added filename encoder for testing

b5c95b4

eshikerya requested review from ijjk, lfades, Timer and timneutkens as code owners August 20, 2019 06:11

Merge branch 'canary' into filename-encoder

2996aa0

Timer requested changes Aug 20, 2019

View reviewed changes

eshikerya added 2 commits August 20, 2019 09:46

fixes in page-loader

ff2691a

Merge branch 'filename-encoder' of https://github.com/eshikerya/next.js…

16b8191

… into filename-encoder

Timer requested changes Aug 20, 2019

View reviewed changes

packages/next/pages/_document.tsx Outdated Show resolved Hide resolved

eshikerya added 3 commits August 22, 2019 16:56

fix possibly undefined

ab5d396

conflict resolution

28072d2

Merge branch 'canary' into filename-encoder

3999687

Merge branch 'canary' into filename-encoder

623f49d

Timer requested changes Aug 23, 2019

View reviewed changes

packages/next/pages/_document.tsx Outdated Show resolved Hide resolved

packages/next/pages/_document.tsx Outdated Show resolved Hide resolved

Update packages/next/pages/_document.tsx

dac1208

Co-Authored-By: Joe Haddad <[email protected]>

move encoding into individual tags as Joe suggested

71d0180

Timer changed the title ~~Fixed dynamic routes issue with AWS S3 static hosting~~ Encode URL paths in HTML and CSR Aug 29, 2019

Timer added this to the 9.0.6 milestone Aug 29, 2019

Timer added the ready to land label Aug 29, 2019

Timer approved these changes Aug 29, 2019

View reviewed changes

Merge branch 'canary' into filename-encoder

067a2fc

Merge branch 'canary' into filename-encoder

53c068d

Timer merged commit 4adf710 into vercel:canary Aug 29, 2019

ijjk mentioned this pull request Sep 18, 2019

Dynamic routes don't work with AWS S3 static hosting #8430

Closed

mattdell mentioned this pull request Nov 21, 2019

Dynamic Route Page JavaScript returns 400 serverless-nextjs/serverless-next.js#243

Closed

vercel locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Encode URL paths in HTML and CSR #8435

Encode URL paths in HTML and CSR #8435

eshikerya commented Aug 20, 2019

eshikerya commented Aug 20, 2019

Timer left a comment

eshikerya commented Aug 20, 2019

Timer commented Aug 20, 2019 •

edited

Loading

eshikerya commented Aug 20, 2019

Timer commented Aug 20, 2019 •

edited

Loading

eshikerya commented Aug 20, 2019

eshikerya commented Aug 21, 2019

timneutkens commented Aug 21, 2019

Timer commented Aug 22, 2019

ijjk commented Aug 22, 2019

Diffs

eshikerya commented Aug 22, 2019

ijjk commented Aug 22, 2019

Diffs

ijjk commented Aug 22, 2019

Diffs

ijjk commented Aug 23, 2019

Diffs

ijjk commented Aug 23, 2019

Diffs

ijjk commented Aug 23, 2019

Diffs

eshikerya commented Aug 29, 2019

Timer left a comment

ijjk commented Aug 29, 2019

Diffs

ijjk commented Aug 29, 2019

Diffs

Encode URL paths in HTML and CSR #8435

Encode URL paths in HTML and CSR #8435

Conversation

eshikerya commented Aug 20, 2019

eshikerya commented Aug 20, 2019

Timer left a comment

Choose a reason for hiding this comment

eshikerya commented Aug 20, 2019

Timer commented Aug 20, 2019 • edited Loading

eshikerya commented Aug 20, 2019

Timer commented Aug 20, 2019 • edited Loading

eshikerya commented Aug 20, 2019

eshikerya commented Aug 21, 2019

timneutkens commented Aug 21, 2019

Timer commented Aug 22, 2019

ijjk commented Aug 22, 2019

Stats from current PR

Diffs

eshikerya commented Aug 22, 2019

ijjk commented Aug 22, 2019

Stats from current PR

Diffs

ijjk commented Aug 22, 2019

Stats from current PR

Diffs

ijjk commented Aug 23, 2019

Stats from current PR

Diffs

ijjk commented Aug 23, 2019

Stats from current PR

Diffs

ijjk commented Aug 23, 2019

Stats from current PR

Diffs

eshikerya commented Aug 29, 2019

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Aug 29, 2019

Stats from current PR

Diffs

ijjk commented Aug 29, 2019

Stats from current PR

Diffs

Timer commented Aug 20, 2019 •

edited

Loading

Timer commented Aug 20, 2019 •

edited

Loading