Remove dependency on ActiveSupport #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- One less dependency to manage - Smaller deployment package for projects that depend on Consult - Replaces String#present? by converting values to string and then checking that length is greater than 0 (nil.to_s is an empty string) - Replaces Hash#deep_symbolize_keys! and Hash#deep_merge with their ActiveSupport implementations
BrianBorge
force-pushed
the
remove-dep-on-activesupport
branch
from
ed555e6 to
c4430c2
Compare
|
Should a revision bump and changelog go along with this? |
That seems reasonable. |
|
Yes, but do it post-merge. You can also be added to the gem committers if you aren't already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Consult's dependency on ActiveSupport. It's one less dependency to manage and a smaller deployment package for projects that depend on Consult that aren't Rails apps.
Addresses #26