Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the dependency on ActiveSupport #26

Closed
BrianBorge opened this issue Jan 24, 2020 · 1 comment
Closed

Consider removing the dependency on ActiveSupport #26

BrianBorge opened this issue Jan 24, 2020 · 1 comment

Comments

@BrianBorge
Copy link
Contributor

Consider removing the dependency on ActiveSupport.

The con here is that Consult would lose access to the set of utility methods ActiveSupport provides, which are nice but Consult makes use of only 3 of these methods.

Removing ActiveSupport would mean one less dependency to manage and a smaller deployment package for projects that take a dependency on Consult.

Consult uses the following ActiveSupport methods:

  • String#present?
  • Hash#deep_symbolize_keys!
  • Hash#deep_merge

Worth ripping out?

@BrianBorge
Copy link
Contributor Author

Addressed by #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant