Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small typo #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix small typo #31

wants to merge 1 commit into from

Conversation

jrmsklar
Copy link

This PR fixes a small typo in the word "incorrect".

@ziogaschr
Copy link
Collaborator

Thanks for the help @jrmsklar.

This PR is partially handled in #27.

Current PR is not backward compatible as it also changes maximumInccorectPasscodeAttempts which is a public property and it might brake current apps using this lib.

@jrmsklar
Copy link
Author

@ziogaschr gotchya 👍.

Will maximumInccorectPasscodeAttempts be updated in that other PR? I think it'd be beneficial to correct that even at the expense of developers updating that name when updating the pod.

@ziogaschr
Copy link
Collaborator

Will maximumInccorectPasscodeAttempts be updated in that other PR?

no, it won't.

@velikanov has a nice list with such typos #9.

I was thinking that we should wait for the next release, let's see what rest people think.

@jrmsklar
Copy link
Author

Sounds good.

@jrmsklar jrmsklar mentioned this pull request Jun 20, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrmsklar @ziogaschr