Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct typos #9

Open
velikanov opened this issue Dec 19, 2015 · 1 comment
Open

Correct typos #9

velikanov opened this issue Dec 19, 2015 · 1 comment
Labels
bug
Milestone
2.0.0

Comments

@velikanov
Copy link
Owner

https://github.com/velikanov/SwiftPasscodeLock/blob/master/PasscodeLock/Protocols/PasscodeLockStateType.swift#L18

https://github.com/velikanov/SwiftPasscodeLock/blob/master/PasscodeLock/Protocols/PasscodeLockConfigurationType.swift#L17

maximumInccorectPasscodeAttempts should be maximumIncorrectPasscodeAttempts

https://github.com/velikanov/SwiftPasscodeLock/blob/master/PasscodeLock/PasscodeLockViewController.swift#L228

animatePlacehodlerAtIndex should be animatePlaceholderAtIndex

unfortunately, fixing this will break backward compatibility in the case when users have created their own States or Configurations (they probably will)
@velikanov velikanov added the bug label Dec 19, 2015
@velikanov velikanov changed the title Correct typo Correct typos Dec 19, 2015
@velikanov velikanov added this to the 2.0.0 milestone Dec 19, 2015
@ziogaschr
Copy link
Collaborator

Nice one for v2.0 indeed.
We can create a migration guide for v2.0 then.

@ziogaschr ziogaschr mentioned this issue Jun 15, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@ziogaschr @velikanov