Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce size of npm packages #3228

Merged
merged 2 commits into from
Dec 23, 2017
Merged

Reduce size of npm packages #3228

merged 2 commits into from
Dec 23, 2017

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Dec 8, 2017 •
edited
Loading

Fixes #3227

$ du -sh package
7.5M	package

$ du -sh package/*
284K	package/_data
 12K	package/bin
5.3M	package/build
1.2M	package/examples
4.0K	package/LICENSE
8.0K	package/package.json
4.0K	package/README.md
788K	package/src
 12K	package/typings

@domoritz domoritz changed the title Update .npmignore to exclude all compiled images and tests. Fixes #3227 Update .npmignore to exclude all compiled images and tests Dec 8, 2017
@domoritz domoritz requested a review from kanitw December 8, 2017 21:30
@domoritz domoritz changed the title Update .npmignore to exclude all compiled images and tests Reduce size of npm packages Dec 8, 2017
@domoritz
Copy link
Member Author

domoritz commented Dec 8, 2017 •
edited
Loading

With the last commit

$ du -sh package
6.1M	package

$ du -sh package/*
 12K	package/bin
5.3M	package/build
4.0K	package/LICENSE
8.0K	package/package.json
4.0K	package/README.md
788K	package/src
 12K	package/typings

kanitw
kanitw approved these changes Dec 11, 2017
View reviewed changes
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If editor and everything else that depends on these examples are still working, I guess this is fine.

@domoritz
Copy link
Member Author

We use git anyway beacuse Vega doesn't ship examples either: https://github.com/vega/editor/blob/master/package.json#L73.

and everything else that depends on these examples
That's why I'm asking you because I wasn't sure who uses examples.

@kanitw
Copy link
Member

kanitw commented Dec 14, 2017 •
edited
Loading

Would this work with the old editor, which we still use as the editor for CompassQL?

@domoritz
Copy link
Member Author

Would this work with the old editor, which we still use as the editor for CompassQL?

It won't copy the examples but you can do that manually. Alternatively, just switch to github urls like we do in the new editor.

@domoritz domoritz merged commit 7a707f9 into master Dec 23, 2017
@domoritz domoritz deleted the dom/ignore-npm branch December 23, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanitw kanitw kanitw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domoritz @kanitw