Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vega lite release package is humongous #3227

Closed
nyurik opened this issue Dec 8, 2017 · 3 comments
Closed

Vega lite release package is humongous #3227

nyurik opened this issue Dec 8, 2017 · 3 comments

Comments

@nyurik
Copy link
Member

nyurik commented Dec 8, 2017

The node_modules/vega-lite dir is 34.1 MB! For comparison, Vega is 2.1MB, and most other well known packages are a tiny fraction of that. Recently, github reduced the size of the release files, which means I can no longer publish release packages that contain the entire node_modules. BTW, this also means that anyone using vega lite lib has to download the whole thing when installing it, even though most of the code is just a few hundred KB.

image

@domoritz
Copy link
Member

domoritz commented Dec 8, 2017

I think a lot of it will be dev dependencies. What's the size when you exclude those?

@nyurik
Copy link
Member Author

nyurik commented Dec 8, 2017

Dev Regular dependencies are only 319KB, plus whichever modules shared by other modules - those would be in the root node_modules/ dir.

image

@nyurik
Copy link
Member Author

nyurik commented Dec 8, 2017

Correction: there are no dev dependencies here - only production dependencies. My code lists vega-lite as a regular dependency, so when I do npm install, the vega-lite lib gets added to node_modules, with all of its production dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants