-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Remove references to archived altair_viewer and altair_saver in ci, docs, and tests. Uninstall anywidget and vl-convert-python during one test run #3419
Conversation
…ython for one build step
…t relevant for vl-convert. This was used for altair_saver which is no longer compatible and maintained
… current GitHub workflow setup
Need to wait for #3418 to be resolved before tests can run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for doing this cleanup @binste!
#3418 is resolved, but tests are not yet happy. It now raises an anywidget dependency issue, see https://github.com/vega/altair/actions/runs/9090334764/job/24983082085. Probably related to this sentence in OP:
Can you have a look to this @binste. Thanks! |
Thank you both! I added |
Now that both altair_viewer and altair_saver are archived and not compatible with Altair anyway, I'd suggest to remove all references to them to clean up the code base a bit. In this PR, I:
webdriver
argument to the.save
method as it's not relevant forvl-convert
. I didn't want to remove it just now as users might still have it set although they have switched tovl-convert
in which case it has just been ignored so far