Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on main due to a fiona/geopandas error #3418

Open
binste opened this issue May 11, 2024 · 6 comments
Open

Tests fail on main due to a fiona/geopandas error #3418

binste opened this issue May 11, 2024 · 6 comments
Assignees
Labels

Comments

@binste
Copy link
Contributor

binste commented May 11, 2024

What happened?

Tests fail, see e.g. https://github.com/vega/altair/actions/runs/9005770219/job/24850952007#step:9:67

I'll look into it. Can't replicate this on my Mac so far.

What would you like to happen instead?

No response

Which version of Altair are you using?

No response

@binste binste added the bug label May 11, 2024
@binste binste self-assigned this May 11, 2024
@mattijn
Copy link
Contributor

mattijn commented May 11, 2024

It's because of this line: https://github.com/vega/altair/blob/main/tests/examples_methods_syntax/interval_selection_map_quakes.py#L14

gdf_quakies = gpd.read_file(data.earthquakes.url, driver="GeoJSON")

Maybe a glitch or something changed in geopandas?

@binste
Copy link
Contributor Author

binste commented May 11, 2024

No new version of geopandas and fiona in the last few days and it only happens for Python 3.11 (consistently across reruns):

image

I can't replicate this with Python 3.11 on Debian and I struggle to install Fiona on the same Ubuntu version as the GitHub runners use.

Maybe some change in a system dependency such as gdal? As it's not related to Altair and it's not blocking any major developments, we could wait a few days to see if this gets resolved somewhere upstream.

UPDATE: In #3419 it happened for Python 3.12...

@mattijn
Copy link
Contributor

mattijn commented May 13, 2024

Raised geopandas/geopandas#3284 at the geopandas repo.

@mattijn
Copy link
Contributor

mattijn commented May 15, 2024

Temporarily fixed by #3421

@mattijn mattijn closed this as completed May 15, 2024
@binste
Copy link
Contributor Author

binste commented May 18, 2024

Thanks @mattijn! Also for engaging in the geopandas discussion.

@binste
Copy link
Contributor Author

binste commented May 18, 2024

Reopening, see geopandas/geopandas#3284 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants