Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Fix test of install script #19425

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Dec 19, 2023

Missed one when updating them in 9893b86. sh.vector.dev is now has a HTTP redirect with the move
to Amplify for hosting (from Netlify).

It is causing a failure here: https://github.com/vectordotdev/vector/actions/runs/7265676030/job/19796083515

Signed-off-by: Jesse Szwedko [email protected]

Missed one when updating them in 9893b86. `sh.vector.dev` is now has a HTTP redirect with the move
to Amplify for hosting (from Netlify).

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko enabled auto-merge December 19, 2023 18:18
@jszwedko jszwedko added this pull request to the merge queue Dec 19, 2023
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/fix-install-script-test
Commit report: 6963807

vector: 0 Failed, 0 New Flaky, 2075 Passed, 0 Skipped, 1m 23.27s Wall Time

Copy link

Regression Detector Results

Run ID: 59f383dd-3eb7-42c5-944a-ca998c850f6a
Baseline: fed76a5
Comparison: babdaa9
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Declared stable experiments that are now erratic

An experiment is erratic (i.e., not stable) if its coefficient of variation is at least 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
splunk_hec_route_s3 ingress throughput +1.21 [+0.68, +1.73] 99.98%
http_to_http_acks ingress throughput +0.74 [-0.58, +2.06] 64.30%
fluent_elasticsearch ingress throughput +0.28 [-0.19, +0.74] 67.39%
file_to_blackhole egress throughput -0.86 [-3.41, +1.69] 41.94%

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
syslog_log2metric_humio_metrics ingress throughput +2.88 [+2.75, +3.01] 100.00%
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +1.78 [+1.66, +1.90] 100.00%
http_text_to_http_json ingress throughput +1.67 [+1.53, +1.82] 100.00%
syslog_splunk_hec_logs ingress throughput +1.58 [+1.52, +1.65] 100.00%
splunk_hec_route_s3 ingress throughput +1.21 [+0.68, +1.73] 99.98%
datadog_agent_remap_datadog_logs ingress throughput +0.91 [+0.79, +1.02] 100.00%
http_to_http_acks ingress throughput +0.74 [-0.58, +2.06] 64.30%
syslog_humio_logs ingress throughput +0.46 [+0.34, +0.58] 100.00%
http_elasticsearch ingress throughput +0.45 [+0.38, +0.53] 100.00%
http_to_s3 ingress throughput +0.30 [+0.03, +0.58] 92.93%
fluent_elasticsearch ingress throughput +0.28 [-0.19, +0.74] 67.39%
http_to_http_noack ingress throughput +0.18 [+0.08, +0.27] 99.83%
http_to_http_json ingress throughput +0.04 [-0.04, +0.11] 57.57%
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.13, +0.14] 2.86%
splunk_hec_indexer_ack_blackhole ingress throughput -0.01 [-0.14, +0.13] 5.32%
otlp_grpc_to_blackhole ingress throughput -0.01 [-0.10, +0.09] 10.54%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.15, +0.08] 40.88%
syslog_regex_logs2metric_ddmetrics ingress throughput -0.08 [-0.22, +0.05] 71.27%
enterprise_http_to_http ingress throughput -0.14 [-0.22, -0.06] 99.60%
syslog_loki ingress throughput -0.40 [-0.47, -0.33] 100.00%
datadog_agent_remap_blackhole ingress throughput -0.46 [-0.58, -0.35] 100.00%
syslog_log2metric_splunk_hec_metrics ingress throughput -0.58 [-0.72, -0.43] 100.00%
socket_to_socket_blackhole ingress throughput -0.68 [-0.83, -0.53] 100.00%
file_to_blackhole egress throughput -0.86 [-3.41, +1.69] 41.94%
datadog_agent_remap_blackhole_acks ingress throughput -1.53 [-1.66, -1.41] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput -1.67 [-1.77, -1.56] 100.00%
otlp_http_to_blackhole ingress throughput -3.56 [-3.76, -3.36] 100.00%

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@jszwedko jszwedko removed this pull request from the merge queue due to a manual request Dec 19, 2023
@jszwedko jszwedko merged commit 0f40989 into master Dec 19, 2023
42 checks passed
@jszwedko jszwedko deleted the jszwedko/fix-install-script-test branch December 19, 2023 20:17
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Missed one when updating them in 9893b86. `sh.vector.dev` is now has a HTTP redirect with the move
to Amplify for hosting (from Netlify).

Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants