-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(install vector): Allow downloading specific versions of Vector #19408
enhancement(install vector): Allow downloading specific versions of Vector #19408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @suikammd !
This would close #5033
Do you mind documenting this in https://github.com/vectordotdev/vector/blob/master/website/content/en/docs/setup/installation/manual/vector-installer.md too?
Hi @jszwedko! |
One of the merge queue checks is currently broken with this PR https://github.com/vectordotdev/vector/actions/runs/7265435178/job/19795281652. This is addressed in #19425 |
Regression Detector ResultsRun ID: 28d0a39f-b282-4280-b70b-d9856afba83e Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | socket_to_socket_blackhole | ingress throughput | +2.06 | [+1.94, +2.17] |
➖ | file_to_blackhole | egress throughput | +1.56 | [-0.93, +4.05] |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | +1.40 | [+1.25, +1.55] |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | +0.88 | [+0.72, +1.04] |
➖ | splunk_hec_route_s3 | ingress throughput | +0.82 | [+0.30, +1.34] |
➖ | fluent_elasticsearch | ingress throughput | +0.66 | [+0.18, +1.14] |
➖ | http_to_s3 | ingress throughput | +0.13 | [-0.15, +0.41] |
➖ | otlp_grpc_to_blackhole | ingress throughput | +0.13 | [+0.03, +0.22] |
➖ | http_to_http_noack | ingress throughput | +0.11 | [-0.00, +0.22] |
➖ | http_to_http_json | ingress throughput | +0.03 | [-0.04, +0.10] |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.01 | [-0.13, +0.15] |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.14, +0.15] |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.02 | [-0.13, +0.10] |
➖ | enterprise_http_to_http | ingress throughput | -0.05 | [-0.13, +0.03] |
➖ | http_elasticsearch | ingress throughput | -0.13 | [-0.20, -0.06] |
➖ | syslog_splunk_hec_logs | ingress throughput | -0.25 | [-0.35, -0.15] |
➖ | syslog_humio_logs | ingress throughput | -0.25 | [-0.37, -0.14] |
➖ | syslog_log2metric_humio_metrics | ingress throughput | -0.26 | [-0.41, -0.12] |
➖ | http_text_to_http_json | ingress throughput | -0.43 | [-0.58, -0.29] |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -0.44 | [-0.52, -0.36] |
➖ | datadog_agent_remap_blackhole | ingress throughput | -0.51 | [-0.61, -0.41] |
➖ | syslog_loki | ingress throughput | -0.64 | [-0.71, -0.57] |
➖ | http_to_http_acks | ingress throughput | -0.94 | [-2.25, +0.37] |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | -1.21 | [-1.31, -1.11] |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -1.27 | [-1.38, -1.16] |
➖ | otlp_http_to_blackhole | ingress throughput | -1.27 | [-1.44, -1.10] |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -2.15 | [-2.28, -2.02] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
…ector (vectordotdev#19408) * feat: support install custom vector version * feat: add documentation for env VECTOR_VERSION --------- Co-authored-by: Doug Smith <[email protected]>
Currently, the VECTOR_VERSION is hardcoded in the script, which restricts users from downloading specific versions of Vector. This pull request aims to allow downloading specific versions of Vector.
Closes #5033