Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space Switching: FAB Cut By Bottom Navigation Bar #6765

Closed
Tracked by #6605
germain-gg opened this issue Aug 8, 2022 · 3 comments · Fixed by #6943
Closed
Tracked by #6605

Space Switching: FAB Cut By Bottom Navigation Bar #6765

germain-gg opened this issue Aug 8, 2022 · 3 comments · Fixed by #6943
Assignees
@fedrunov
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

IMG_20220808_093818

Outcome

What did you expect?

What happened instead?

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No
@germain-gg germain-gg added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout labels Aug 8, 2022
@ericdecanini
Copy link
Contributor

ericdecanini commented Aug 9, 2022 •
edited
Loading

@gsouquet Can you give more context or a screen recording of this happening? I'm unable to reproduce this on my devices

@germain-gg
Copy link
Contributor Author

I don't particularly have clear steps but I often ended up in that state after navigating the app, scrolling up/down, ...
Not sure a screen recording will help very much here

@ericdecanini
Copy link
Contributor

This issue becomes present when we remove the bottom navigation bar (i.e. when space switching and edit layout are combined). This commit is a quick fix for it, but should be looked at and merged as a separate fix

6ff80d2

@ericdecanini ericdecanini mentioned this issue Aug 17, 2022
Closed
27 tasks
@ericdecanini ericdecanini changed the title FAB cut by bottom navigation bar Space Switching: FAB Cut By Bottom Navigation Bar Aug 17, 2022
@fedrunov fedrunov assigned fedrunov and unassigned ericdecanini Aug 23, 2022
This was referenced Aug 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedrunov fedrunov

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fabs are moved from HomeRoomListFragment to NewHomeDetailFragment element-hq/element-android
3 participants
@germain-gg @ericdecanini @fedrunov