Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fabs are moved from HomeRoomListFragment to NewHomeDetailFragment #6943

Merged
merged 3 commits into from
Aug 29, 2022
Merged

fabs are moved from HomeRoomListFragment to NewHomeDetailFragment #6943

merged 3 commits into from
Aug 29, 2022

Conversation

fedrunov
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

in new app layout fabs go offscreen when toolbar is expanded

Motivation and context

closes #6765

@fedrunov fedrunov requested a review from ericdecanini August 25, 2022 15:44
@ElementBot
Copy link

ElementBot commented Aug 25, 2022 •
edited
Loading

Warnings
⚠️

vector/src/main/res/layout/fragment_room_list.xml#L38 - Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)
⚠️

vector/src/main/res/layout/fragment_room_list.xml#L38 - Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)
⚠️

vector/src/main/res/layout/fragment_room_list.xml#L54 - Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)
⚠️

vector/src/main/res/layout/fragment_room_list.xml#L54 - Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)

Generated by 🚫 dangerJS against d159e07

Merge branch 'develop' into bugfix/nfe/app_layout_fabs_position
d159e07 
# Conflicts:
#	vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@fedrunov fedrunov merged commit 14e3753 into develop Aug 29, 2022
@fedrunov fedrunov deleted the bugfix/nfe/app_layout_fabs_position branch August 29, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdecanini ericdecanini ericdecanini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Space Switching: FAB Cut By Bottom Navigation Bar
3 participants
@fedrunov @ElementBot @ericdecanini