-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bottom navigation tabs are removed for AppLayout #6905
Conversation
# Conflicts: # vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small remark otherwise LGTM
// Update the navigation view if needed (for when we restore the tabs) | ||
views.bottomNavigationView.selectedItemId = it.currentTab.toMenuId() | ||
childFragmentManager.commitTransaction { | ||
add(R.id.roomListContainer, HomeRoomListFragment::class.java, null, "HOME_ROOM_LIST") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create constant for "HOME_ROOM_LIST"?
# Conflicts: # vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt
There is a separate issue for this - #6765. This PR does not cause this problem, it just makes fabs be lower than now and so they are cut off instead of bottom navigation bar |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* develop: (169 commits) new app layouts invites (#6911) bottom navigation tabs are removed for AppLayout (#6905) focus input when changing server address Fix copyright Improve createRoomThreePidEvents for clarity Remove roomCreatorUserId and use current userId by default Remove useless explicit field type Change visibility of LocalRoomThirdPartyInviteContent to internal Remove useless apply in CreateLocalRoomStateEventsTask Update doc Extract condition to reduce code complexity Verify tombstone event Remove safe call Add unit tests for CreateRoomFromLocalRoomTask Add unit tests for CreateLocalRoomStateEventsTask Set stateKey as empty by default Create local room state events in dedicated task Fix local events generation following the specification Update CreateRoomParams from the potential FeaturePreset before persisting Persists CreateRoomParams into LocalRoomSummaryEntity ... # Conflicts: # vector/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt
…e/ons/device_manager_other_session_list * feature/ons/device_manager_current_session: (169 commits) new app layouts invites (#6911) bottom navigation tabs are removed for AppLayout (#6905) focus input when changing server address Fix copyright Improve createRoomThreePidEvents for clarity Remove roomCreatorUserId and use current userId by default Remove useless explicit field type Change visibility of LocalRoomThirdPartyInviteContent to internal Remove useless apply in CreateLocalRoomStateEventsTask Update doc Extract condition to reduce code complexity Verify tombstone event Remove safe call Add unit tests for CreateRoomFromLocalRoomTask Add unit tests for CreateLocalRoomStateEventsTask Set stateKey as empty by default Create local room state events in dedicated task Fix local events generation following the specification Update CreateRoomParams from the potential FeaturePreset before persisting Persists CreateRoomParams into LocalRoomSummaryEntity ... # Conflicts: # vector/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt
Type of change
Content
removes bottom navigation tabs from new home screen
Motivation and context
part of #6502
closes #6565