Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottom navigation tabs are removed for AppLayout #6905

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

fedrunov
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

removes bottom navigation tabs from new home screen

Motivation and context

part of #6502
closes #6565

Sorry, something went wrong.

@fedrunov fedrunov requested review from a team, ganfra and ericdecanini and removed request for a team August 22, 2022 10:53
# Conflicts:
#	vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remark otherwise LGTM

// Update the navigation view if needed (for when we restore the tabs)
views.bottomNavigationView.selectedItemId = it.currentTab.toMenuId()
childFragmentManager.commitTransaction {
add(R.id.roomListContainer, HomeRoomListFragment::class.java, null, "HOME_ROOM_LIST")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create constant for "HOME_ROOM_LIST"?

@DoM1niC
Copy link

DoM1niC commented Aug 23, 2022

Appbar / Navbar issue the Fab Buttons here ...
grafik

NIkita Fedrunov added 2 commits August 25, 2022 13:22
# Conflicts:
#	vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt
@fedrunov fedrunov requested a review from ganfra August 25, 2022 11:24
@fedrunov
Copy link
Contributor Author

Appbar / Navbar issue the Fab Buttons here ... grafik

There is a separate issue for this - #6765. This PR does not cause this problem, it just makes fabs be lower than now and so they are cut off instead of bottom navigation bar

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedrunov fedrunov merged commit 225d05e into develop Aug 25, 2022
@fedrunov fedrunov deleted the feature/nfe/app_layout_bottom_tabs_removal branch August 25, 2022 13:59
onurays added a commit that referenced this pull request Aug 26, 2022
* develop: (169 commits)
  new app layouts invites (#6911)
  bottom navigation tabs are removed for AppLayout (#6905)
  focus input when changing server address
  Fix copyright
  Improve createRoomThreePidEvents for clarity
  Remove roomCreatorUserId and use current userId by default
  Remove useless explicit field type
  Change visibility of LocalRoomThirdPartyInviteContent to internal
  Remove useless apply in CreateLocalRoomStateEventsTask
  Update doc
  Extract condition to reduce code complexity
  Verify tombstone event
  Remove safe call
  Add unit tests for CreateRoomFromLocalRoomTask
  Add unit tests for CreateLocalRoomStateEventsTask
  Set stateKey as empty by default
  Create local room state events in dedicated task
  Fix local events generation following the specification
  Update CreateRoomParams from the potential FeaturePreset before persisting
  Persists CreateRoomParams into LocalRoomSummaryEntity
  ...

# Conflicts:
#	vector/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt
onurays added a commit that referenced this pull request Aug 26, 2022
…e/ons/device_manager_other_session_list

* feature/ons/device_manager_current_session: (169 commits)
  new app layouts invites (#6911)
  bottom navigation tabs are removed for AppLayout (#6905)
  focus input when changing server address
  Fix copyright
  Improve createRoomThreePidEvents for clarity
  Remove roomCreatorUserId and use current userId by default
  Remove useless explicit field type
  Change visibility of LocalRoomThirdPartyInviteContent to internal
  Remove useless apply in CreateLocalRoomStateEventsTask
  Update doc
  Extract condition to reduce code complexity
  Verify tombstone event
  Remove safe call
  Add unit tests for CreateRoomFromLocalRoomTask
  Add unit tests for CreateLocalRoomStateEventsTask
  Set stateKey as empty by default
  Create local room state events in dedicated task
  Fix local events generation following the specification
  Update CreateRoomParams from the potential FeaturePreset before persisting
  Persists CreateRoomParams into LocalRoomSummaryEntity
  ...

# Conflicts:
#	vector/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppLayout: Remove bottom tabs from home screen
4 participants