This repository has been archived by the owner on Jul 17, 2020. It is now read-only.
fix(__dirname): adds horrible wrapper hack for __dirname with webpack… #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & electron & workers This is an abominable hack which works around the fact webpack just does whatever the fuck it wants with workers. We stall everything in the worker until we've sent it the correct path to the .asar, then in the NDI store module we temporarily set the location of grandiose within the .asar. Guaranteed this will come back to bite us in the arse. fix #114
|
👋 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… & electron & workers
This is an abominable hack which works around the fact webpack just does whatever the fuck it wants with workers. We stall everything in the worker until we've sent it the correct path to the .asar, then in the NDI store module we temporarily set the location of grandiose within the .asar.
Guaranteed this will come back to bite us in the arse.
fix #114