Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Electron build with asar and native modules causes a path resolve error #114

Closed
2xAA opened this issue May 22, 2020 · 1 comment · Fixed by #115
Closed

Electron build with asar and native modules causes a path resolve error #114

2xAA opened this issue May 22, 2020 · 1 comment · Fixed by #115
Labels
bug Something isn't working

Comments

@2xAA
Copy link
Member

2xAA commented May 22, 2020

See electron/packager#740.

Fix: disable asar. CHUNKY APPS INCOMING.

@2xAA 2xAA added the bug Something isn't working label May 22, 2020
@2xAA
Copy link
Member Author

2xAA commented May 23, 2020

Disabling asar may be premature. Making sure __dirname is the same between the worker and the renderer process is key here, then grandiose should be able to find the bindings.

Though finding the correct configuration for this is proving difficult.

2xAA added a commit that referenced this issue May 23, 2020
… & electron & workers

This is an abominable hack which works around the fact webpack just does whatever the fuck it wants
with workers. We stall everything in the worker until we've sent it the correct path to the .asar,
then in the NDI store module we temporarily set the location of grandiose within the .asar.
Guaranteed this will come back to bite us in the arse.

fix #114
@2xAA 2xAA closed this as completed in #115 May 23, 2020
2xAA added a commit that referenced this issue May 23, 2020
… & electron & workers (#115)

This is an abominable hack which works around the fact webpack just does whatever the fuck it wants
with workers. We stall everything in the worker until we've sent it the correct path to the .asar,
then in the NDI store module we temporarily set the location of grandiose within the .asar.
Guaranteed this will come back to bite us in the arse.

fix #114
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant