Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expressions are not working anymore #594

Closed
TimPietrusky opened this issue Jun 24, 2021 · 4 comments · Fixed by #595
Closed

Expressions are not working anymore #594

TimPietrusky opened this issue Jun 24, 2021 · 4 comments · Fixed by #595
Labels
bug Something isn't working dependencies Pull requests that update a dependency file released

Comments

@TimPietrusky
Copy link
Member

TimPietrusky commented Jun 24, 2021 •
edited
Loading

Operating system and application version

  • OS: Ubuntu 20.04
  • Version: 3.17.1

Describe the bug
When you enter something into an expression, and error is shown in the console.

To Reproduce
Steps to reproduce the behavior:

  1. Add a module to a group
  2. Click on a property of the module
  3. Expand "expression" in the Input Config
  4. Do any change in the textarea and click outside of it
  5. See that there is an error in the console
Worker caught an error: TypeError: Cannot read property 'parse' of undefined
    at compileExpression (expressions.js?8a2f:24)

Expected behavior
We can change the expression.

Additional context
When starting modV in dev-mode, I see this message:

warning  in ./src/application/worker/store/modules/expressions.js
"export 'default' (imported as 'math') was not found in 'mathjs'
@2xAA
Copy link
Member

2xAA commented Jun 25, 2021

mathjs.patch.txt

This will fix things, but I'd like to investigate why this happened. Packages shouldn't just suddenly break like that.

@2xAA
Copy link
Member

2xAA commented Jun 25, 2021

#582

It was PAST ME 😧

Not sure why dependabot is suggesting we jump major versions, but I should've reviewed more carefully.

2xAA added a commit that referenced this issue Jun 25, 2021
@2xAA
fix(mathjs): updates mathjs to v7 from v3
a649a49 
fixes #594
@2xAA 2xAA mentioned this issue Jun 25, 2021
Merged
@2xAA 2xAA added bug Something isn't working dependencies Pull requests that update a dependency file labels Jun 25, 2021
TimPietrusky added a commit that referenced this issue Jun 25, 2021
@2xAA @TimPietrusky
fix(mathjs): updates mathjs to v7 from v3 (#595)
32585cc 
* fix(mathjs): updates mathjs to v7 from v3

fixes #594

* chore(mathjs): Remove console.log

Co-authored-by: Tim Pietrusky <[email protected]>
2xAA pushed a commit that referenced this issue Jun 30, 2021
@semantic-release-bot
chore(release): 3.17.2
8511342 
## [3.17.2](3.17.1...3.17.2) (2021-06-30)

### Bug Fixes

* **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9))
* fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590)
* **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594)
@2xAA
Copy link
Member

2xAA commented Jun 30, 2021

🎉 This issue has been resolved in version 3.17.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@2xAA 2xAA added the released label Jun 30, 2021
2xAA pushed a commit that referenced this issue Jul 1, 2021
@semantic-release-bot
chore(release): 3.18.0
cd07cba 
# [3.18.0](3.17.1...3.18.0) (2021-07-01)

### Bug Fixes

* updates a group's outputContext name when group's name is updated ([#604](#604)) ([a0db3c9](a0db3c9)), closes [#599](#599)
* **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9))
* fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590)
* **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594)

### Features

* **fft:** adds fft ([#611](#611)) ([f9f2b90](f9f2b90))
* **grabCanvas:** Adds grab-canvas as a plugin ([#612](#612)) ([d7ca887](d7ca887)), closes [#366](#366) [#366](#366)
* adds localStorage saving for audio and video inputs ([#608](#608)) ([33109cd](33109cd)), closes [#470](#470)
* **gallery:** updates ordering of modules to be alphabetical ([#606](#606)) ([48f0075](48f0075)), closes [#605](#605)
* **group-inheritance:** adds group inheritance option ([#607](#607)) ([1894eda](1894eda)), closes [#603](#603)
@2xAA
Copy link
Member

2xAA commented Jul 1, 2021

🎉 This issue has been resolved in version 3.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

2xAA pushed a commit that referenced this issue Jan 7, 2022
@semantic-release-bot @2xAA
chore(release): 3.17.2
5e3b444 
## [3.17.2](3.17.1...3.17.2) (2021-06-30)

### Bug Fixes

* **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9))
* fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590)
* **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594)
2xAA pushed a commit that referenced this issue Jan 7, 2022
@semantic-release-bot @2xAA
chore(release): 3.18.0
3663754 
# [3.18.0](3.17.1...3.18.0) (2021-07-01)

### Bug Fixes

* updates a group's outputContext name when group's name is updated ([#604](#604)) ([a0db3c9](a0db3c9)), closes [#599](#599)
* **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9))
* fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590)
* **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594)

### Features

* **fft:** adds fft ([#611](#611)) ([f9f2b90](f9f2b90))
* **grabCanvas:** Adds grab-canvas as a plugin ([#612](#612)) ([d7ca887](d7ca887)), closes [#366](#366) [#366](#366)
* adds localStorage saving for audio and video inputs ([#608](#608)) ([33109cd](33109cd)), closes [#470](#470)
* **gallery:** updates ordering of modules to be alphabetical ([#606](#606)) ([48f0075](48f0075)), closes [#605](#605)
* **group-inheritance:** adds group inheritance option ([#607](#607)) ([1894eda](1894eda)), closes [#603](#603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mathjs): updates mathjs to v7 from v3 vcync/modV
2 participants
@TimPietrusky @2xAA