Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[preset] Save / Load audio / video input config #470

Closed
TimPietrusky opened this issue Dec 1, 2020 · 4 comments · Fixed by #608
Closed

[preset] Save / Load audio / video input config #470

TimPietrusky opened this issue Dec 1, 2020 · 4 comments · Fixed by #608
Labels
enhancement Feature requests released

Comments

@TimPietrusky
Copy link
Member

Is your feature request related to a problem? Please describe.
After configuring the audio / video input, it would be nice to save that into a preset and to be able to load it when the preset is loaded.

Describe the solution you'd like
I save the preset, I load the preset and my audio / video config is restored.

Describe alternatives you've considered
Set the audio / video config every time I start modV.
@TimPietrusky TimPietrusky added the enhancement Feature requests label Dec 1, 2020
@2xAA
Copy link
Member

2xAA commented Dec 1, 2020

This can be added with createPresetData and loadPresetData actions in the relevant store module.
See src\application\worker\store\modules\expressions.js as an example.

@2xAA
Copy link
Member

2xAA commented Jul 1, 2021 •
edited
Loading

@TimPietrusky Would it be preferable to save the audio and video inputs in modV's localStorage instead?
It would keep presets portable and most likely your audio and video setup won't need to change between presets on the same machine.

I'm also drawing inspiration from DAWs such as Ableton or Logic Pro X and A/V software like Resolume. Audio device in/out is stored as a user setting, not in the project file.

@TimPietrusky
Copy link
Member Author

@2xAA yes that would be perfect!

2xAA added a commit that referenced this issue Jul 1, 2021
@2xAA
feat: adds localStorage saving for audio and video inputs
a8b9d65 
removes vuex-localstorage in favour of vuex-persistedstate

fixes #470
2xAA added a commit that referenced this issue Jul 1, 2021
@2xAA
feat: adds localStorage saving for audio and video inputs
7fe7bbe 
removes vuex-localstorage in favour of vuex-persistedstate

fixes #470
2xAA added a commit that referenced this issue Jul 1, 2021
@2xAA
feat: adds localStorage saving for audio and video inputs
d10c86f 
removes vuex-localstorage in favour of vuex-persistedstate

fixes #470
@2xAA 2xAA mentioned this issue Jul 1, 2021
Merged
TimPietrusky pushed a commit that referenced this issue Jul 1, 2021
@2xAA
feat: adds localStorage saving for audio and video inputs (#608)
33109cd 
removes vuex-localstorage in favour of vuex-persistedstate

fixes #470
2xAA pushed a commit that referenced this issue Jul 1, 2021
@semantic-release-bot
chore(release): 3.18.0
cd07cba 
# [3.18.0](3.17.1...3.18.0) (2021-07-01)

### Bug Fixes

* updates a group's outputContext name when group's name is updated ([#604](#604)) ([a0db3c9](a0db3c9)), closes [#599](#599)
* **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9))
* fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590)
* **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594)

### Features

* **fft:** adds fft ([#611](#611)) ([f9f2b90](f9f2b90))
* **grabCanvas:** Adds grab-canvas as a plugin ([#612](#612)) ([d7ca887](d7ca887)), closes [#366](#366) [#366](#366)
* adds localStorage saving for audio and video inputs ([#608](#608)) ([33109cd](33109cd)), closes [#470](#470)
* **gallery:** updates ordering of modules to be alphabetical ([#606](#606)) ([48f0075](48f0075)), closes [#605](#605)
* **group-inheritance:** adds group inheritance option ([#607](#607)) ([1894eda](1894eda)), closes [#603](#603)
@2xAA
Copy link
Member

2xAA commented Jul 1, 2021

🎉 This issue has been resolved in version 3.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@2xAA 2xAA added the released label Jul 1, 2021
2xAA pushed a commit that referenced this issue Jan 7, 2022
@semantic-release-bot @2xAA
chore(release): 3.18.0
3663754 
# [3.18.0](3.17.1...3.18.0) (2021-07-01)

### Bug Fixes

* updates a group's outputContext name when group's name is updated ([#604](#604)) ([a0db3c9](a0db3c9)), closes [#599](#599)
* **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9))
* fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590)
* **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594)

### Features

* **fft:** adds fft ([#611](#611)) ([f9f2b90](f9f2b90))
* **grabCanvas:** Adds grab-canvas as a plugin ([#612](#612)) ([d7ca887](d7ca887)), closes [#366](#366) [#366](#366)
* adds localStorage saving for audio and video inputs ([#608](#608)) ([33109cd](33109cd)), closes [#470](#470)
* **gallery:** updates ordering of modules to be alphabetical ([#606](#606)) ([48f0075](48f0075)), closes [#605](#605)
* **group-inheritance:** adds group inheritance option ([#607](#607)) ([1894eda](1894eda)), closes [#603](#603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adds localStorage saving for audio and video inputs vcync/modV
2 participants
@TimPietrusky @2xAA