fix: fixes loading presets with textures referencing groups #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates groups and outputContexts to share the same ID on creation. This fixes bad references when loading presets with texture types saved with a group reference fixes #590
|
Tested it and it doesn't work for me. When loading the preset and clicking on Steps to reproduce:
|
|
@TimPietrusky the canvas is the correct one it seems, just we're not reflecting that it's the one for the group in the UI. |
the group texture type is identical to the canvas type, but it signals to the UI to show it as a group instead. re #590
|
@TimPietrusky please can you test again with the new commit? |
TimPietrusky
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Tested and works. Thank you very much <3
Opened a new ticket for the "renamed group"-bug as mentioned above: #599
2xAA
pushed a commit
that referenced
this pull request
Jun 30, 2021
## [3.17.2](3.17.1...3.17.2) (2021-06-30) ### Bug Fixes * **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9)) * fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590) * **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594)
|
🎉 This PR is included in version 3.17.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2xAA
pushed a commit
that referenced
this pull request
Jul 1, 2021
# [3.18.0](3.17.1...3.18.0) (2021-07-01) ### Bug Fixes * updates a group's outputContext name when group's name is updated ([#604](#604)) ([a0db3c9](a0db3c9)), closes [#599](#599) * **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9)) * fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590) * **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594) ### Features * **fft:** adds fft ([#611](#611)) ([f9f2b90](f9f2b90)) * **grabCanvas:** Adds grab-canvas as a plugin ([#612](#612)) ([d7ca887](d7ca887)), closes [#366](#366) [#366](#366) * adds localStorage saving for audio and video inputs ([#608](#608)) ([33109cd](33109cd)), closes [#470](#470) * **gallery:** updates ordering of modules to be alphabetical ([#606](#606)) ([48f0075](48f0075)), closes [#605](#605) * **group-inheritance:** adds group inheritance option ([#607](#607)) ([1894eda](1894eda)), closes [#603](#603)
|
🎉 This PR is included in version 3.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2xAA
pushed a commit
that referenced
this pull request
Jan 7, 2022
## [3.17.2](3.17.1...3.17.2) (2021-06-30) ### Bug Fixes * **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9)) * fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590) * **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594)
2xAA
pushed a commit
that referenced
this pull request
Jan 7, 2022
# [3.18.0](3.17.1...3.18.0) (2021-07-01) ### Bug Fixes * updates a group's outputContext name when group's name is updated ([#604](#604)) ([a0db3c9](a0db3c9)), closes [#599](#599) * **deps:** Use correct format to load vcync/interactive-shader-format-js ([553f4f9](553f4f9)) * fixes loading presets with textures referencing groups ([#591](#591)) ([9dfeff5](9dfeff5)), closes [#590](#590) [#590](#590) * **mathjs:** updates mathjs to v7 from v3 ([#595](#595)) ([32585cc](32585cc)), closes [#594](#594) ### Features * **fft:** adds fft ([#611](#611)) ([f9f2b90](f9f2b90)) * **grabCanvas:** Adds grab-canvas as a plugin ([#612](#612)) ([d7ca887](d7ca887)), closes [#366](#366) [#366](#366) * adds localStorage saving for audio and video inputs ([#608](#608)) ([33109cd](33109cd)), closes [#470](#470) * **gallery:** updates ordering of modules to be alphabetical ([#606](#606)) ([48f0075](48f0075)), closes [#605](#605) * **group-inheritance:** adds group inheritance option ([#607](#607)) ([1894eda](1894eda)), closes [#603](#603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates groups and outputContexts to share the same ID on creation. This fixes bad references when loading presets with texture types saved with a group reference
fixes #590