-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove unnecessary punctuation #4833
Conversation
|
WalkthroughThe changes in this pull request focus on enhancing the documentation for the Vben Vxe Table component. Key modifications include refining the introduction to clarify the integration with the Vben Form, expanding the adapters section, updating code snippets for custom cell rendering, and providing a detailed explanation of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/src/components/common-ui/vben-vxe-table.md (1)
Line range hint
279-289
: Documentation structure needs improvement.A few issues were found in the documentation:
- Duplicate heading "## Props" (appears twice)
- The events description uses an emoji (⌚️) which seems out of place in technical documentation
Consider these improvements:
-## Props - -所有属性都可以传入 `useVbenVxeGrid` 的第一个参数中。 - -| 属性名 | 描述 | 类型 | -| -------------- | ------------------ | ------------------- | -| tableTitle | 表格标题 | `string` | -| tableTitleHelp | 表格标题帮助信息 | `string` | -| gridClass | grid组件的class | `string` | -| gridOptions | grid组件的参数 | `VxeTableGridProps` | -| gridEvents | grid组件的触发的⌚️ | `VxeGridListeners` | -| formOptions | 表单参数 | `VbenFormProps` | +### Component Props + +所有属性都可以传入 `useVbenVxeGrid` 的第一个参数中。 + +| 属性名 | 描述 | 类型 | +| -------------- | ---------------- | ------------------- | +| tableTitle | 表格标题 | `string` | +| tableTitleHelp | 表格标题帮助信息 | `string` | +| gridClass | grid组件的class | `string` | +| gridOptions | grid组件的参数 | `VxeTableGridProps` | +| gridEvents | grid组件的事件 | `VxeGridListeners` | +| formOptions | 表单参数 | `VbenFormProps` |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
docs/src/components/common-ui/vben-vxe-table.md
(1 hunks)
🔇 Additional comments (1)
docs/src/components/common-ui/vben-vxe-table.md (1)
115-115
: LGTM! Clear and concise explanation added.
The added explanation about the flat structure of tree table data is helpful for users implementing this feature.
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
useVbenVxeGrid
function.