-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add vxe-table export example #4769
Conversation
|
WalkthroughThe changes in this pull request introduce the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
vxe-table 导出功能依赖 VxeUI.saveFile 工具函数来下载文件,此工具函数在 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
packages/effects/plugins/src/vxe-table/init.ts (1)
96-96
: Component registration looks correct but may be unnecessary.
The registration follows the established pattern, but if VxeUpload isn't required for export functionality, we should remove both the import and this registration to keep the bundle size optimal.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- packages/effects/plugins/src/vxe-table/init.ts (2 hunks)
- playground/src/views/examples/vxe-table/remote.vue (2 hunks)
🔇 Additional comments (1)
playground/src/views/examples/vxe-table/remote.vue (1)
49-49
: Verify export performance with large datasets.
The export functionality has been enabled in the toolbar. Since this is a remote data grid, consider the performance implications when exporting large datasets.
Consider implementing these improvements:
- Add a loading indicator during export
- Implement pagination or chunking for large exports
- Add server-side export handling for very large datasets
Example implementation for loading state:
toolbarConfig: {
custom: true,
- export: true,
+ export: {
+ showLoading: true,
+ message: 'Exporting data...'
+ },
refresh: true,
zoom: true,
},
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
New Features
VxeUpload
component to enhance file upload capabilities within theVxeUI
component library.Improvements
exportConfig
property for better data management.