Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/self): ability to share VMs by default #6838

Merged
merged 6 commits into from
May 25, 2023
Merged

feat(xo-web/self): ability to share VMs by default #6838

merged 6 commits into from
May 25, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented May 17, 2023 •
edited
Loading

See xoa-support#7420

Screenshot

Capture d’écran de 2023-05-17 15-31-11

Description

At self service creation/edition, a checkbox is added to setup the default value of "Share VM" for users of the self service.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this May 17, 2023
@MathieuRA MathieuRA requested a review from ggunullu May 17, 2023 13:32
@MathieuRA MathieuRA marked this pull request as ready for review May 17, 2023 13:32
@MathieuRA MathieuRA requested a review from pdonias May 22, 2023 07:22
pdonias
pdonias requested changes May 23, 2023
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-server/src/api/resource-set.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from ggunullu May 24, 2023 10:00
@MathieuRA MathieuRA requested a review from pdonias May 24, 2023 11:24
@pdonias pdonias changed the title feat(xo-web/resourceSet): checkbox for default value of 'share VM' feat(xo-web/self): ability to share VMs by default May 25, 2023
@pdonias pdonias merged commit f4bf56f into master May 25, 2023
@pdonias pdonias deleted the resource-set-share-vm branch May 25, 2023 09:00
This was referenced Jun 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

@ggunullu ggunullu ggunullu approved these changes

Assignees

@MathieuRA MathieuRA

Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathieuRA @pdonias @ggunullu