Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backups): add settings to force snapshotting during VM backup #6221

Merged
merged 6 commits into from
May 17, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 6, 2022

Fixes zammad#6735

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the feat_force_offline_snapshot branch from cb979a2 to 9461cf3 Compare May 6, 2022 13:07
@fbeauchamp fbeauchamp force-pushed the feat_force_offline_snapshot branch from 9461cf3 to 1eb0a48 Compare May 6, 2022 14:53
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp force-pushed the feat_force_offline_snapshot branch from e69ca83 to 7f7c34f Compare May 13, 2022 14:17
@fbeauchamp fbeauchamp requested a review from julien-f May 17, 2022 06:56
@fbeauchamp fbeauchamp force-pushed the feat_force_offline_snapshot branch from 70732e1 to d937f1e Compare May 17, 2022 08:47
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@julien-f julien-f changed the title feat(backups): add config file settings to force snapshot of offline … feat(backups): add settings to force snapshotting during VM backup May 17, 2022
@julien-f julien-f merged commit 5db4083 into master May 17, 2022
@julien-f julien-f deleted the feat_force_offline_snapshot branch May 17, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants