feat(backups): add config file settings to force snapshot of offline …

…WM wen using snapshot mode
vatesfr · May 6, 2022 · 9461cf3 · 9461cf3
1 parent df07d4a
commit 9461cf3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/@xen-orchestra/backups/_VmBackup.js b/@xen-orchestra/backups/_VmBackup.js
@@ -173,7 +173,11 @@ class VmBackup {
     const settings = this._settings
 
     const doSnapshot =
-      this._isDelta || (!settings.offlineBackup && vm.power_state === 'Running') || settings.snapshotRetention !== 0
+      this._isDelta ||
+      (!settings.offlineBackup && vm.power_state === 'Running') ||
+      settings.snapshotRetention !== 0 ||
+      // https://help.vates.fr/#ticket/zoom/6735
+      (settings.offlineSnapshot && settings.snapshotHaltedVmWhenUsingOfflineSnapshot)
     if (doSnapshot) {
       await Task.run({ name: 'snapshot' }, async () => {
         if (!settings.bypassVdiChainsCheck) {

diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -7,6 +7,8 @@
 
 > Users must be able to say: “Nice enhancement, I'm eager to test it”
 
+- [Disaster Recovery] add a setting `snapshotHaltedVmWhenUsingOfflineSnapshot` to force a snapshot even when the WM is halted and using `offline snapshot` mode (PR [#6221](https://github.com/vatesfr/xen-orchestra/pull/6221))
+
 ### Bug fixes
 
 > Users must be able to say: “I had this issue, happy to know it's fixed”
@@ -33,5 +35,4 @@
 
 <!--packages-start-->
 
-
 <!--packages-end-->
diff --git a/packages/xo-server/config.toml b/packages/xo-server/config.toml
@@ -109,6 +109,7 @@ offlineSnapshot = false
 snapshotRetention = 0
 timeout = 0
 vmTimeout = 0
+snapshotHaltedVmWhenUsingOfflineSnapshot = true
 
 # This is a work-around.
 #