Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should fix #615 and #554 #627

Merged
merged 2 commits into from
May 16, 2022
Merged

should fix #615 and #554 #627

merged 2 commits into from
May 16, 2022

Conversation

EverettBerry
Copy link
Contributor

also addresses closed issues #274, #353, #385, #426, #529, and #543

We can also upgrade https://cdn.datatables.net/buttons/ which is now on version 2.2.3 and we are using version 1.2.4 (see base.mako)

There are still state management issues. For availability zones, you must have it as a showing column first. Then when you change the region the AZ will change. If you have the AZ column hidden, change the reason, then show it, the AZ will be us-east-1

@EverettBerry EverettBerry requested a review from brookemckim May 14, 2022 17:43
@Bensign
Copy link
Contributor

Bensign commented May 14, 2022

@EverettBerry Awesome. I'm impressed with how simple this fix ended up being.

Copy link
Contributor

@brookemckim brookemckim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants