fix(onboarding): revert default of CPV screen to be in onboarding #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4876 +/- ##
==========================================
- Coverage 85.42% 85.41% -0.02%
==========================================
Files 735 735
Lines 29933 29933
Branches 5256 5256
==========================================
- Hits 25571 25566 -5
- Misses 4114 4119 +5
Partials 248 248
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
commented
Feb 8, 2024
| @@ -31,7 +31,7 @@ export default function LinkPhoneNumber({ navigation }: Props) { | |||
|
|
|||
| const continueButtonOnPress = async () => { | |||
| ValoraAnalytics.track(OnboardingEvents.link_phone_number) | |||
| navigate(Screens.VerificationStartScreen, { isOnboarding: false }) | |||
| navigate(Screens.VerificationStartScreen, { hasOnboarded: false }) | |||
There was a problem hiding this comment.
Setting this to false here since it's technically still onboarding, we can reconsider this if we change the initial screen to be LinkPhoneNumber if the user completes cloud recovery and bails on this screen or the phone verification screen. cc @finnian0826
MuckT
reviewed
Feb 8, 2024
| // Disable iOS back during onboarding | ||
| gestureEnabled: !route.params?.isOnboarding, | ||
| gestureEnabled: !!route.params?.hasOnboarded, |
There was a problem hiding this comment.
nit: Does this need to be forced to a boolean?
Suggested change
| gestureEnabled: !!route.params?.hasOnboarded, | |
| gestureEnabled: route.params?.hasOnboarded, |
There was a problem hiding this comment.
it has to be forced to a boolean. The default value is true
MuckT
approved these changes
Feb 8, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…lora-inc#4876) ### Description Fixes a bug introduced in valora-inc#4834 , where VerificationStartScreen defaulted to being not in onboarding. This causes an issue if a user bails on the screen during onboarding. On restart, the screen is loaded in the already onboarded mode where the back button does nothing and there's no option to skip (see before video below). This PR reverts the default to be in onboarding as it doesn't seem trivial to pass props on the initialRoute. ### Test plan Unit tests and manual Before: https://github.com/valora-inc/wallet/assets/5062591/496876ec-4adf-48b8-8a12-72d9030f3e37 After: https://github.com/valora-inc/wallet/assets/5062591/8d345432-4fcb-439f-b63a-03806d5959e0 ### Related issues N/A ### Backwards compatibility Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug introduced in #4834 , where VerificationStartScreen defaulted to being not in onboarding. This causes an issue if a user bails on the screen during onboarding. On restart, the screen is loaded in the already onboarded mode where the back button does nothing and there's no option to skip (see before video below). This PR reverts the default to be in onboarding as it doesn't seem trivial to pass props on the initialRoute.
Test plan
Unit tests and manual
Before:
onboarding-cpv-bug-before.mp4
After:
onboarding-cpv-bug-after.mp4
Related issues
N/A
Backwards compatibility
Yes