feat(onboarding): remove steps on phone verification screen when importing #4834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-ravi
commented
Jan 31, 2024
| // Disable iOS back during onboarding | ||
| gestureEnabled: route.params?.hideOnboardingStep ? false : true, | ||
| gestureEnabled: !route.params?.isOnboarding, |
| @@ -23,12 +23,10 @@ import { StatsigExperiments } from 'src/statsig/types' | |||
| export const END_OF_ONBOARDING_SCREENS = [Screens.WalletHome, Screens.ChooseYourAdventure] | |||
|
|
|||
| interface NavigatorFunctions { | |||
| navigate: typeof NavigationService.navigate | ((screen: Screens) => void) | |||
There was a problem hiding this comment.
this dummy type (for calculating total steps) wasn't allowing setting screen props, updated the fn below to match navigate's type
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4834 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 728 728
Lines 29520 29522 +2
Branches 5173 5172 -1
=======================================
+ Hits 25202 25204 +2
Misses 4072 4072
Partials 246 246
Continue to review full report in Codecov by Sentry.
|
MuckT
approved these changes
Feb 2, 2024
satish-ravi
added a commit
that referenced
this pull request
Feb 8, 2024
) ### Description Fixes a bug introduced in #4834 , where VerificationStartScreen defaulted to being not in onboarding. This causes an issue if a user bails on the screen during onboarding. On restart, the screen is loaded in the already onboarded mode where the back button does nothing and there's no option to skip (see before video below). This PR reverts the default to be in onboarding as it doesn't seem trivial to pass props on the initialRoute. ### Test plan Unit tests and manual Before: https://github.com/valora-inc/wallet/assets/5062591/496876ec-4adf-48b8-8a12-72d9030f3e37 After: https://github.com/valora-inc/wallet/assets/5062591/8d345432-4fcb-439f-b63a-03806d5959e0 ### Related issues N/A ### Backwards compatibility Yes
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…lora-inc#4876) ### Description Fixes a bug introduced in valora-inc#4834 , where VerificationStartScreen defaulted to being not in onboarding. This causes an issue if a user bails on the screen during onboarding. On restart, the screen is loaded in the already onboarded mode where the back button does nothing and there's no option to skip (see before video below). This PR reverts the default to be in onboarding as it doesn't seem trivial to pass props on the initialRoute. ### Test plan Unit tests and manual Before: https://github.com/valora-inc/wallet/assets/5062591/496876ec-4adf-48b8-8a12-72d9030f3e37 After: https://github.com/valora-inc/wallet/assets/5062591/8d345432-4fcb-439f-b63a-03806d5959e0 ### Related issues N/A ### Backwards compatibility Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes steps on phone verification screen when importing. Refactored the screen to accept a property
isOnboardinginstead ofhideOnboardingStepwhich was used to identify whether the user is in the onboarding flow and whether to show steps or not.Also fixed a bug where iOS gestures where disabled when not in onboarding instead of onboarding
Test plan
Unit tests, manual
Related issues
Backwards compatibility
Yes