Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Cache server version #3254

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Python: Cache server version #3254

merged 4 commits into from
Feb 25, 2025

Conversation

edlng
Copy link
Collaborator

@edlng edlng commented Feb 24, 2025

This PR caches the server version to avoid redundant calls to info for other tests.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@edlng edlng added python Python wrapper testing Everything about testing labels Feb 24, 2025
@edlng edlng requested a review from a team as a code owner February 24, 2025 19:19
@edlng
Copy link
Collaborator Author

edlng commented Feb 24, 2025

lint issue: awaiting #3220 to be merged.

@edlng edlng merged commit eee5d17 into valkey-io:main Feb 25, 2025
22 checks passed
@edlng edlng deleted the python/edlng-cache-server-version branch February 25, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrinkman jbrinkman jbrinkman approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees
No one assigned
Labels
python Python wrapper testing Everything about testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlng @jbrinkman @Yury-Fridlyand