Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Added skip markers to tests #3220

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Python: Added skip markers to tests #3220

merged 5 commits into from
Feb 24, 2025

Conversation

edlng
Copy link
Collaborator

@edlng edlng commented Feb 21, 2025

Replaced old Python code that handled incompatible versions.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@edlng edlng requested a review from a team as a code owner February 21, 2025 00:54
@edlng edlng marked this pull request as draft February 21, 2025 00:58
@edlng
Copy link
Collaborator Author

edlng commented Feb 21, 2025

Note: rust-lang/rust-clippy#14272

currently there's an issue with rust linter

@edlng edlng marked this pull request as ready for review February 22, 2025 05:18
@edlng edlng added python Python wrapper testing Everything about testing labels Feb 24, 2025
yipin-chen
yipin-chen approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edlng edlng mentioned this pull request Feb 24, 2025
Merged
6 tasks
Yury-Fridlyand
Yury-Fridlyand reviewed Feb 24, 2025
View reviewed changes
@edlng edlng force-pushed the python/edlng-skip-attribute branch from 9a9d0b0 to c12e97c Compare February 24, 2025 19:54
@Yury-Fridlyand Yury-Fridlyand merged commit 707ed4b into valkey-io:main Feb 24, 2025
22 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the python/edlng-skip-attribute branch February 24, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
python Python wrapper testing Everything about testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlng @Yury-Fridlyand @yipin-chen