Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node tests - transactions fix #2611

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Node tests - transactions fix #2611

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dfe1207
node tests - delete WAIT test and update inactive to idle in versions…
Nov 5, 2024
999ecbb
prettier
Nov 5, 2024
b41b6bc
fixes
Muhammad-awawdi-amazon Nov 6, 2024
32265ab
prettier
Muhammad-awawdi-amazon Nov 6, 2024
c876100
apply WAIT for versions >=7.0.0
Muhammad-awawdi-amazon Nov 6, 2024
69515ac
prettier #2
Muhammad-awawdi-amazon Nov 6, 2024
6f909ed
deleted test
Muhammad-awawdi-amazon Nov 6, 2024
77e8e35
Merge branch 'release-1.2' into transactions2-fix
avifenesh Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions node/tests/SharedTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10637,8 +10637,8 @@ export function runBaseTests(config: {
expect(result[0].pending).toEqual(1);
expect(result[0].idle).toBeGreaterThan(0);

if (!cluster.checkIfServerVersionLessThan("7.2.0")) {
expect(result[0].inactive).toBeGreaterThan(0);
if (cluster.checkIfServerVersionLessThan("7.2.0")) {
expect(result[0].idle).toBeGreaterThan(0); // Use `idle` for Redis versions before 7.2.0
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idle is checked 2 lines above

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yury-Fridlyand Deleted the WAIT transactions test completley.
I've seen in your PR you're running this test for versions greater than 7.0.0. but note that it's also failing for 7.2
the whole WAIT in the transactions is flaky as it seems to be relevant to how fast the engine handles it, sometimes it does succeed on 6.2 and sometimes it fails, so we can't be completely sure how it behaves
Anyhow, we agreed upon deleting the test and merging this PR since we need it ASAP

}

expect(
Expand Down
Loading