Node tests - transactions fix #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… past 7.2.0 Signed-off-by: Ubuntu <[email protected]>
Muhammad-awawdi-amazon
force-pushed
the
transactions2-fix
branch
from
7c7b5ad to
dfe1207
Compare
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Ubuntu <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Yury-Fridlyand
previously requested changes
Nov 5, 2024
node/tests/SharedTests.ts
Outdated
| if (!cluster.checkIfServerVersionLessThan("7.2.0")) { | ||
| expect(result[0].inactive).toBeGreaterThan(0); | ||
| if (cluster.checkIfServerVersionLessThan("7.2.0")) { | ||
| expect(result[0].idle).toBeGreaterThan(0); // Use `idle` for Redis versions before 7.2.0 |
There was a problem hiding this comment.
idle is checked 2 lines above
There was a problem hiding this comment.
@Yury-Fridlyand Deleted the WAIT transactions test completley.
I've seen in your PR you're running this test for versions greater than 7.0.0. but note that it's also failing for 7.2
the whole WAIT in the transactions is flaky as it seems to be relevant to how fast the engine handles it, sometimes it does succeed on 6.2 and sometimes it fails, so we can't be completely sure how it behaves
Anyhow, we agreed upon deleting the test and merging this PR since we need it ASAP
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Muhammad-awawdi-amazon
changed the title
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
avifenesh
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
avifenesh
approved these changes
Nov 6, 2024
The change will be just removing wait from transaction, if you have disagreement, we will discuss a change base on decision. |
avifenesh
dismissed
Yury-Fridlyand’s stale review
Overiding since we merging a specific change, the discussion is still open if you see fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2622
Checklist
Before submitting the PR make sure the following are checked: