Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: add SRANDMEMBER command #2067

Merged
merged 9 commits into from
Aug 7, 2024

Conversation

acarbonetto
Copy link
Contributor

Replaces: #1938

Adds SRANDMEMBER

shohamazon and others added 2 commits July 31, 2024 22:54
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto added the node Node.js wrapper label Aug 1, 2024
@acarbonetto acarbonetto self-assigned this Aug 1, 2024
@acarbonetto acarbonetto requested a review from a team as a code owner August 1, 2024 06:05
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming Guian's comments are addressed

@acarbonetto acarbonetto merged commit 1b5c73b into valkey-io:main Aug 7, 2024
8 checks passed
@acarbonetto acarbonetto deleted the node/acarbo_srandmember branch August 7, 2024 16:59
GumpacG pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Aug 7, 2024
* Node: add SRANDMEMBER command

---------

Signed-off-by: Shoham Elias <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Aug 12, 2024
* Node: add SRANDMEMBER command

---------

Signed-off-by: Shoham Elias <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants