Node: add SRANDMEMBER command #1938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shoham Elias <[email protected]>
shohamazon
force-pushed
the
node/srandmember
branch
from
89bf5a5 to
53c1be5
Compare
Yury-Fridlyand
approved these changes
Jul 15, 2024
| * See https://valkey.io/commands/srandmember for more details. | ||
| * | ||
| * @param key - The key from which to retrieve the set member. | ||
| * @returns a random element from the set, or null if `key` does not exist. |
There was a problem hiding this comment.
Suggested change
| * @returns a random element from the set, or null if `key` does not exist. | |
| * @returns A random element from the set, or null if `key` does not exist. |
Should we capitalize? If not, please ignore
| * @param count - The number of members to return. | ||
| * If `count` is positive, returns unique members. | ||
| * If `count` is negative, allows for duplicates members. | ||
| * @returns a list of members from the set. If the set does not exist or is empty, an empty list will be returned. |
There was a problem hiding this comment.
Suggested change
| * @returns a list of members from the set. If the set does not exist or is empty, an empty list will be returned. | |
| * @returns A list of members from the set. If the set does not exist or is empty, an empty list will be returned. |
Same here
| * See https://valkey.io/commands/srandmember for more details. | ||
| * | ||
| * @param key - The key from which to retrieve the set member. | ||
| * Command Response - a random element from the set, or null if `key` does not exist. |
There was a problem hiding this comment.
Suggested change
| * Command Response - a random element from the set, or null if `key` does not exist. | |
| * Command Response - A random element from the set, or null if `key` does not exist. |
| * @param count - The number of members to return. | ||
| * If `count` is positive, returns unique members. | ||
| * If `count` is negative, allows for duplicates members. | ||
| * Command Response - a list of members from the set. If the set does not exist or is empty, an empty list will be returned. |
There was a problem hiding this comment.
Suggested change
| * Command Response - a list of members from the set. If the set does not exist or is empty, an empty list will be returned. | |
| * Command Response - A list of members from the set. If the set does not exist or is empty, an empty list will be returned. |
| public async srandmemberCount( | ||
| key: BulkString, | ||
| count: number, | ||
| ): Promise<BulkString[]> { |
There was a problem hiding this comment.
I think we need to merge #1953 ahead of this
|
Can we close this because of duplicate PRs? #2067 @acarbonetto |
|
Closing - this command is completed under #2067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.