Python: add BLPOP and BRPOP commands #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
requested review from
Yury-Fridlyand,
acarbonetto,
GumpacG,
jonathanl-bq and
tjzhang-BQ
aaron-congo
changed the title
Yury-Fridlyand
approved these changes
May 1, 2024
|
|
||
| Notes: | ||
| 1: BLPOP is a client blocking command, see https://github.com/aws/glide-for-redis/wiki/General-Concepts#blocking-commands for more details and best practices. | ||
| 2: When in cluster mode, all keys must map to the same hash slot. |
There was a problem hiding this comment.
Suggested change
| 2: When in cluster mode, all keys must map to the same hash slot. | |
| 2: When in cluster mode, all `keys` must map to the same hash slot. |
There was a problem hiding this comment.
I've changed these docs to align with existing doc patterns. The patterns I've noticed and followed are:
- use angle quotes only for argument names, unless the argument is plural (eg
keys,membersetc) or we are describing the arg itself in the "Args" section - do not use "Note" or "Notes" as this isn't used elsewhere, instead include the hash slot and/or blocking command warnings on their own separated lines in the doc
acarbonetto
approved these changes
May 2, 2024
aaron-congo
force-pushed
the
python/integ_acongo_blpop_brpop
branch
from
4edabf8 to
75f4552
Compare
This was referenced May 2, 2024
Yury-Fridlyand
approved these changes
May 2, 2024
acarbonetto
reviewed
May 6, 2024
Elen-Ghulam
approved these changes
May 6, 2024
tjzhang-BQ
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
May 8, 2024
* Python: add BLPOP and BRPOP commands (#196) Co-authored-by: Andrew Carbonetto <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Python: add BLPOP and BRPOP commands (#196) Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://valkey.io/commands/blpop/
https://valkey.io/commands/brpop/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.