Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: add BLPOP and BRPOP commands #196

Merged

Conversation

aaron-congo
Copy link

@aaron-congo aaron-congo commented Apr 5, 2024

Issue #, if available:
N/A

Description of changes:

Note: depends on valkey-io#1239

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Yury-Fridlyand
Copy link

Pick doc changes from #198

@acarbonetto acarbonetto changed the title Python: add BLPOP and BRPOP commands [BLOCKED] Python: add BLPOP and BRPOP commands Apr 12, 2024
@jonathanl-bq
Copy link

Approved on condition that you make Yury's suggested changes around Redis versioning.

@acarbonetto acarbonetto removed their assignment Apr 16, 2024
@aaron-congo aaron-congo changed the title [BLOCKED] Python: add BLPOP and BRPOP commands Python: add BLPOP and BRPOP commands Apr 24, 2024
@aaron-congo aaron-congo force-pushed the python/integ_acongo_blpop_brpop branch from db932d0 to e5702c3 Compare April 25, 2024 00:27
@aaron-congo aaron-congo force-pushed the python/dev_acongo_blpop_brpop branch from 62c0103 to 2967c3d Compare April 25, 2024 01:13
@aaron-congo aaron-congo force-pushed the python/dev_acongo_blpop_brpop branch from 885a37d to 5176883 Compare April 25, 2024 16:09
Copy link

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG to upstream without CI part
This should be fixed in another PR and merged ahead of code changes.

@aaron-congo aaron-congo force-pushed the python/dev_acongo_blpop_brpop branch from ae0514e to 02795e3 Compare April 30, 2024 21:06
@aaron-congo aaron-congo force-pushed the python/dev_acongo_blpop_brpop branch from c8c037b to c212e88 Compare May 1, 2024 17:37
@aaron-congo aaron-congo merged commit 56ce21d into python/integ_acongo_blpop_brpop May 1, 2024
6 checks passed
@aaron-congo aaron-congo deleted the python/dev_acongo_blpop_brpop branch May 1, 2024 17:51
aaron-congo added a commit that referenced this pull request May 2, 2024
Yury-Fridlyand pushed a commit that referenced this pull request May 7, 2024
* Python: add BLPOP and BRPOP commands (#196)

Co-authored-by: Andrew Carbonetto <[email protected]>
tjzhang-BQ pushed a commit that referenced this pull request May 8, 2024
* Python: add BLPOP and BRPOP commands (#196)

Co-authored-by: Andrew Carbonetto <[email protected]>
cyip10 pushed a commit that referenced this pull request Jun 24, 2024
* Python: add BLPOP and BRPOP commands (#196)

Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants