Skip to content

Commit

Permalink
Addressed PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: Guian Gumpac <[email protected]>
  • Loading branch information
GumpacG committed Aug 1, 2024
1 parent 0999cc1 commit e09f583
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions node/src/BaseClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4173,7 +4173,7 @@ export class BaseClient {
* See https://valkey.io/commands/zscan for more details.
*
* @param key - The key of the sorted set.
* @param cursor - The cursor that points to the next iteration of results. A value of "0" indicates the start of
* @param cursor - The cursor that points to the next iteration of results. A value of `"0"` indicates the start of
* the search.
* @param options - (Optional) The zscan options.
* @returns An `Array` of the `cursor` and the subset of the sorted set held by `key`.
Expand Down Expand Up @@ -4210,7 +4210,7 @@ export class BaseClient {
key: string,
cursor: string,
options?: BaseScanOptions,
): Promise<[string, [string]]> {
): Promise<[string, string[]]> {
return this.createWritePromise(createZScan(key, cursor, options));
}

Expand Down
2 changes: 1 addition & 1 deletion node/src/Transaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2489,7 +2489,7 @@ export class BaseTransaction<T extends BaseTransaction<T>> {
* See https://valkey.io/commands/zscan for more details.
*
* @param key - The key of the sorted set.
* @param cursor - The cursor that points to the next iteration of results. A value of "0" indicates the start of
* @param cursor - The cursor that points to the next iteration of results. A value of `"0"` indicates the start of
* the search.
* @param options - (Optional) The zscan options.
*
Expand Down
2 changes: 1 addition & 1 deletion node/tests/SharedTests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5740,7 +5740,7 @@ export function runBaseTests<Context>(config: {
const numberMap: Record<string, number> = {};
const expectedNumberMapArray: string[] = [];

for (let i = 0; i < 1000; i++) {
for (let i = 0; i < 10000; i++) {
expectedNumberMapArray.push(i.toString());
expectedNumberMapArray.push(i.toString());
numberMap[i.toString()] = i;
Expand Down

0 comments on commit e09f583

Please sign in to comment.