Addressed PR comments

Signed-off-by: Guian Gumpac <[email protected]>
valkey-io · Jul 31, 2024 · 0999cc1 · 0999cc1
1 parent 631da9e
commit 0999cc1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/node/npm/glide/index.ts b/node/npm/glide/index.ts
@@ -148,7 +148,6 @@ function initialize() {
         ScoreFilter,
         SignedEncoding,
         UnsignedEncoding,
-        ZScanOptions,
         createLeakedArray,
         createLeakedAttribute,
         createLeakedBigint,
@@ -232,7 +231,6 @@ function initialize() {
         ScoreFilter,
         SignedEncoding,
         UnsignedEncoding,
-        ZScanOptions,
         createLeakedArray,
         createLeakedAttribute,
         createLeakedBigint,

diff --git a/node/src/BaseClient.ts b/node/src/BaseClient.ts
@@ -4185,25 +4185,19 @@ export class BaseClient {
      * @example
      * ```typescript
      * // Assume "key" contains a sorted set with multiple members
-     * let resultCursor = "1";
      * let newCursor = "0";
      * let result = [];
      *
-     * while (resultCursor !== "0") {
-     *      result = await client.zscan("key", newCursor, {
+     * do {
+     *      result = await client.zscan(key1, newCursor, {
      *          match: "*",
      *          count: 5,
      *      });
      *      newCursor = result[0];
      *      console.log("Cursor: ", newCursor);
      *      console.log("Members: ", result[1]);
-     *
-     *      if (newCursor === "0") {
-     *          break;
-     *      }
-     *
-     *      resultCursor = newCursor;
-     * }
+     * } while (newCursor !== "0");
+     * // The output of the code above is something similar to:
      * // Cursor:  123
      * // Members:  ['value 163', '163', 'value 114', '114', 'value 25', '25', 'value 82', '82', 'value 64', '64']
      * // Cursor:  47