Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hams #112

Merged
merged 9 commits into from
May 9, 2019
+69 −0
Merged

Feature/hams #112

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4abab51
Add ham test
May 8, 2019
b85425a
Add ham generator
May 8, 2019
ee018e8
Move ham test data to the bottom of the json file
May 8, 2019
793cdc4
Move ham data to the bottom of the json file
May 8, 2019
1ded90c
Update README.md
erikpoort May 8, 2019
42e52e9
Add ham to faker
May 9, 2019
0ce3d63
Add test to validate that the ham parser
May 9, 2019
47c98c0
Merge branch 'upstream/master' into feature/hams
May 9, 2019
e057c97
Merge branch 'upstream/master' into feature/hams
May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add ham test
Erik Poort committed May 8, 2019
commit 4abab518ce2488956535984b983bb0e35c61f9f4
6 changes: 6 additions & 0 deletions Fakery.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
@@ -178,6 +178,8 @@
D59B6D391D99C82E007CB072 /* NumberSpec.swift in Sources */ = {isa = PBXBuildFile; fileRef = D59B6CFC1D99C5FD007CB072 /* NumberSpec.swift */; };
D59B6D3A1D99C82E007CB072 /* PhoneNumberSpec.swift in Sources */ = {isa = PBXBuildFile; fileRef = D59B6CFD1D99C5FD007CB072 /* PhoneNumberSpec.swift */; };
D59B6D3B1D99C82E007CB072 /* TeamSpec.swift in Sources */ = {isa = PBXBuildFile; fileRef = D59B6CFE1D99C5FD007CB072 /* TeamSpec.swift */; };
F7A019902283206600B92D39 /* HamSpec.swift in Sources */ = {isa = PBXBuildFile; fileRef = F7A0198F22831FCB00B92D39 /* HamSpec.swift */; };
F7A019912283206600B92D39 /* HamSpec.swift in Sources */ = {isa = PBXBuildFile; fileRef = F7A0198F22831FCB00B92D39 /* HamSpec.swift */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
@@ -272,6 +274,7 @@
D59B6D131D99C6C7007CB072 /* Info-Tests-Mac.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = "Info-Tests-Mac.plist"; sourceTree = "<group>"; };
D59B6D141D99C6C7007CB072 /* Info-Tests-tvOS.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = "Info-Tests-tvOS.plist"; sourceTree = "<group>"; };
D59B6D151D99C6C7007CB072 /* Info-tvOS.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = "Info-tvOS.plist"; sourceTree = "<group>"; };
F7A0198F22831FCB00B92D39 /* HamSpec.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HamSpec.swift; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
@@ -482,6 +485,7 @@
D59B6CFC1D99C5FD007CB072 /* NumberSpec.swift */,
D59B6CFD1D99C5FD007CB072 /* PhoneNumberSpec.swift */,
D59B6CFE1D99C5FD007CB072 /* TeamSpec.swift */,
F7A0198F22831FCB00B92D39 /* HamSpec.swift */,
105747991F6FBAA500154ECB /* BankSpec.swift */,
AC88DC0C215330A3007198E6 /* DateSpec.swift */,
);
@@ -913,6 +917,7 @@
D59B6D2E1D99C82E007CB072 /* ParserSpec.swift in Sources */,
D59B6D321D99C82E007CB072 /* BusinessSpec.swift in Sources */,
D59B6D3B1D99C82E007CB072 /* TeamSpec.swift in Sources */,
F7A019912283206600B92D39 /* HamSpec.swift in Sources */,
D59B6D3A1D99C82E007CB072 /* PhoneNumberSpec.swift in Sources */,
D59B6D2C1D99C82E007CB072 /* ConfigSpec.swift in Sources */,
D59B6D381D99C82E007CB072 /* NameSpec.swift in Sources */,
@@ -964,6 +969,7 @@
D59B6D1E1D99C82D007CB072 /* ParserSpec.swift in Sources */,
D59B6D221D99C82D007CB072 /* BusinessSpec.swift in Sources */,
D59B6D2B1D99C82D007CB072 /* TeamSpec.swift in Sources */,
F7A019902283206600B92D39 /* HamSpec.swift in Sources */,
D59B6D2A1D99C82D007CB072 /* PhoneNumberSpec.swift in Sources */,
D59B6D1C1D99C82D007CB072 /* ConfigSpec.swift in Sources */,
D59B6D281D99C82D007CB072 /* NameSpec.swift in Sources */,
3 changes: 3 additions & 0 deletions Resources/Locales/en-TEST.json
View file
Original file line number Diff line number Diff line change
@@ -98,6 +98,9 @@
"creature": ["owls"],
"name": ["#{Address.state} #{creature}"]
},
"ham": {
"name": ["Smithfield Ham"]
},
"hacker": {
"abbreviation": ["TCP"],
"adjective": ["open-source"],
23 changes: 23 additions & 0 deletions Tests/Fakery/Generators/HamSpec.swift
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import Quick
import Nimble
@testable import Fakery

final class HamSpec: QuickSpec {
override func spec() {
describe("Ham") {
var ham: Ham!

beforeEach {
let parser = Parser(locale: "en-TEST")
ham = Ham(parser: parser)
}

describe("#name") {
it("returns the correct text") {
let name = ham.name()
expect(name).to(equal("Smithfield Ham"))
}
}
}
}
}