Feature/hams #112
Merged
Feature/hams #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erikpoort Could you also update the README.md with some usage instructions? |
|
I hammered in a piece of example code, it's cured now. |
|
Smokin' ham dude! Thanx |
vadymmarkov
reviewed
May 9, 2019
There was a problem hiding this comment.
Nice one @erikpoort 😅 I think we should also add this generator to https://github.com/vadymmarkov/Fakery/blob/master/Sources/Fakery/Faker.swift to make it accessible.
added 4 commits
May 9, 2019 16:03
# Conflicts: # Fakery.xcodeproj/project.pbxproj # README.md # Resources/Locales/en-TEST.json # Resources/Locales/en.json # Sources/Fakery/Faker.swift # Tests/Fakery/FakerSpec.swift
# Conflicts: # Resources/Locales/en-TEST.json # Resources/Locales/en.json
|
@vadymmarkov had to resolve some conflicts, but it's ready! |
|
Great @erikpoort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vadymmarkov,
I added a nice feature!
It generates different types of hams in English.
Could benefit some people :)