Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Germany holidays: add Liberation from Nazi Regime Day 2025 in Berlin #2052

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

hf-kklein
Copy link
Contributor

source: https://www.berlin.de/aktuelles/9188766-958090-einmaliger-feiertag-am-8-mai-2025.html

fixes #2051

Sorry, didn't get my setup ready to generate the snapshots.

@KJhellico
Copy link
Collaborator

@hf-kklein, thank you for your contribution! However, we implement such one-time holidays as “special holidays” (see similar holiday in 2020).

@PPsyrius
Copy link
Collaborator

PPsyrius commented Oct 17, 2024

@hf-kklein Check your git repo, I've created a PR that addresses all the issues above as well as adding translations, test cases, and updated snapshots. 🙏

@arkid15r @KJhellico We should probably add a new entry for may_8 victory day in the international holiday group as they're currently in use by France, Czechia, Slovakia, and Ukraine.

I'm not sure if I can come up with a name for it though - USSR-derived ones that are celebrated on May 9th currently use _add_world_war_two_victory_day at the moment

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb25790) to head (2de76a3).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2052   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       190           
  Lines        11539     11539           
  Branches      1743      1743           
=========================================
  Hits         11539     11539           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PPsyrius
Copy link
Collaborator

@hf-kklein Don't forget to add your name to the AUTHORS file as well :)

Copy link

@hf-kklein
Copy link
Contributor Author

hf-kklein commented Oct 17, 2024

Don't forget to add your name to the AUTHORS file as well :)

I'm fine without it :) In the end, you did all the work! thanks! I'm fine with my role as issue reporter 😀

@hf-kklein hf-kklein marked this pull request as ready for review October 17, 2024 05:30
@hf-kklein
Copy link
Contributor Author

after the merge, a version bump would be highly appreciated :)

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KJhellico KJhellico changed the title feat: Add Liberation from Nazi Regime Day 2025 - Berlin, Germany (DE-BE) Update Germany holidays: add Liberation from Nazi Regime Day 2025 in Berlin Oct 17, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @hf-kklein!

@arkid15r
Copy link
Collaborator

after the merge, a version bump would be highly appreciated :)

If you mean releasing the new version -- it's going to be the next Mon, Oct 21st.

@arkid15r arkid15r added this pull request to the merge queue Oct 17, 2024
Merged via the queue into vacanza:dev with commit b0a7ecb Oct 17, 2024
29 checks passed
@hf-kklein hf-kklein deleted the 2025-05-08-de-be branch October 17, 2024 16:58
hf-kklein added a commit to hf-kklein/bdew-datetimes that referenced this pull request Oct 17, 2024
…efreiung")

it's not released yet but will include a fix for vacanza/holidays#2051

will be released on Oct 21st vacanza/holidays#2052 (comment)
@KJhellico KJhellico mentioned this pull request Oct 21, 2024
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "Tag der Befreiung" 2025-05-08: One-Time Holiday in Berlin, Germany (DE-BE)
4 participants