-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Germany holidays: add Liberation from Nazi Regime Day 2025 in Berlin #2052
Conversation
@hf-kklein, thank you for your contribution! However, we implement such one-time holidays as “special holidays” (see similar holiday in 2020). |
@hf-kklein Check your git repo, I've created a PR that addresses all the issues above as well as adding translations, test cases, and updated snapshots. 🙏 @arkid15r @KJhellico We should probably add a new entry for I'm not sure if I can come up with a name for it though - USSR-derived ones that are celebrated on May 9th currently use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2052 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 190 190
Lines 11539 11539
Branches 1743 1743
=========================================
Hits 11539 11539 ☔ View full report in Codecov by Sentry. |
@hf-kklein Don't forget to add your name to the AUTHORS file as well :) |
|
I'm fine without it :) In the end, you did all the work! thanks! I'm fine with my role as issue reporter 😀 |
after the merge, a version bump would be highly appreciated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @hf-kklein!
If you mean releasing the new version -- it's going to be the next Mon, Oct 21st. |
…efreiung") it's not released yet but will include a fix for vacanza/holidays#2051 will be released on Oct 21st vacanza/holidays#2052 (comment)
…Berlin (vacanza#2052) Co-authored-by: Konstantin <[email protected]> Co-authored-by: PPsyrius <[email protected]>
source: https://www.berlin.de/aktuelles/9188766-958090-einmaliger-feiertag-am-8-mai-2025.html
fixes #2051
Sorry, didn't get my setup ready to generate the snapshots.