Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation, testcase for Berlin's 80th Liberation Day #1

Conversation

PPsyrius
Copy link

Proposed change

Hi, I've switched your coding implementation to the special_holiday category which is more suitable for one-time holidays like this, as well as adding translation, testcase, and snapshots for it.

Thanks again for your contribution :)

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@hf-kklein hf-kklein merged commit 53f07b5 into hf-kklein:2025-05-08-de-be Oct 17, 2024
@PPsyrius PPsyrius deleted the BE_80th_liberation_day_translation_testcase branch October 26, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants