Add translation, testcase for Berlin's 80th Liberation Day #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Hi, I've switched your coding implementation to the
special_holiday
category which is more suitable for one-time holidays like this, as well as adding translation, testcase, and snapshots for it.Thanks again for your contribution :)
Type of change
holidays
functionality in general)Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally