Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus in MS touchscreen devices, fixes #237 #249

Merged
merged 4 commits into from
Jun 7, 2016
Merged

Fix focus in MS touchscreen devices, fixes #237 #249

merged 4 commits into from
Jun 7, 2016

Conversation

manolo
Copy link
Member

@manolo manolo commented Jun 3, 2016

fixes #237


This change is Reviewable

@manolo manolo mentioned this pull request Jun 4, 2016
@platosha
Copy link
Contributor

platosha commented Jun 6, 2016

:lgtm:

Previously, manolo (Manuel Carrasco Moñino) wrote…

Fix focus in MS touchscreen devices, fixes #237

fixes #237


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@platosha
Copy link
Contributor

platosha commented Jun 6, 2016

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@Saulis
Copy link
Contributor

Saulis commented Jun 6, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


vaadin-combo-box.html, line 169 [r2] (raw file):

          key-event-target>
      <div suffix id="clearIcon" on-tap="_clear"
           on-touchend="_preventDefault" on-down="_preventDefault">

Can the on-touchend be removed?


Comments from Reviewable

@manolo
Copy link
Member Author

manolo commented Jun 7, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


vaadin-combo-box.html, line 169 [r2] (raw file):

Previously, Saulis (Sauli Tähkäpää) wrote…

Can the on-touchend be removed?

Done.

Comments from Reviewable

@platosha
Copy link
Contributor

platosha commented Jun 7, 2016

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@manolo manolo merged commit b5d005f into master Jun 7, 2016
@manolo manolo deleted the fix/237 branch June 7, 2016 10:07
@manolo manolo removed the in review label Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus on element after click
3 participants