Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus on element after click #237

Closed
JosefJezek opened this issue May 9, 2016 · 4 comments · Fixed by #249
Closed

Focus on element after click #237

JosefJezek opened this issue May 9, 2016 · 4 comments · Fixed by #249
Assignees
Labels
bug Something isn't working
Milestone

Comments

@JosefJezek
Copy link

JosefJezek commented May 9, 2016

I have issue with focus on the element after click with left button, right button is ok.

I have Chrome Version 50.0.2661.94 m on Windows 10 64b. I tested this issue in incognito window.

nimbus-record-video
First click is left button and second click is right button.

After remove on-down="_preventDefault" from paper-input-container element is focus ok after click left button.

https://github.com/vaadin/vaadin-combo-box/blob/master/vaadin-combo-box.html#L148

@jouni
Copy link
Member

jouni commented May 9, 2016

Hi! I don’t completely understand the issue?

The dropdown is supposed to open when you click the input, so the behavior is expected for the left button click. For right clicking, perhaps we should open the dropdown from that as well, but I’m not sure.

@JosefJezek
Copy link
Author

I have the issue with loss focus after click for enable writing to input element.

@Saulis
Copy link
Contributor

Saulis commented May 11, 2016

Tested on a Surface Pro running Chrome 50 and Windows 10, and combo-box does not focus on left click. Right click does focus. Tapping with a finger does focus. Firefox and Edge work normally also with a mouse.

On a Windows 10 VM and Chrome 50 mouse works normally, so to me it seems to be a touch device issue.

@JosefJezek do you happen to have a MS Surface or a laptop with a touch screen?

@JosefJezek
Copy link
Author

@Saulis Yes, I have Dell notebook with touch screen.

@Saulis Saulis added this to the 1.0.1 milestone Jun 3, 2016
@platosha platosha added the bug Something isn't working label Jun 3, 2016
manolo added a commit that referenced this issue Jun 7, 2016
Fix focus in MS touchscreen devices, fixes #237
@manolo manolo removed the in review label Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants